Changing "Create new account" button text breaks admin/user/user/create form

Why not use the language system or settings.php string array (which is new) to do this?

Agree with @catch but hardcoding parameters is not the way to go.

This patch eliminates the t('Create new account') and t('Search') from user_admin function. I tested and it works but more testing is needed to verify that not affects other functionality.

Well, this would be quite a paradigm shift for Drupal form flows. We have this kind of op = t() check all over the place.

Yes, it makes sense, and it would be great to clean it up in Drupal 7. Unfortunately this is such a paradigm shift for core that it is late to do it right now in Drupal 6. We risk introducing numerous new bugs. Until then, you can try nasty tricks to put back the original button title in a custom validation callback. (I never tried but I'd expect that it works).

This patch fails against core, so I am setting it to code needs work.

I just wanted to put in my vote for this fix. While the language system is the ideal, many regular drupal users can't afford the overhead to turn that on and need to resort to theming to control the display of form elements like this.

I would really appreciate seeing this fix in the core at some point in the future.

Using hook_form_alter() or the theming system to change that is *not* the way to go.

You will want to use the language system (which don't require enabling the locale module at all) to change the strings. One easy way to do this is by using the String Overrides module, but you can also override strings from your settings.php file.

Given this, this is probably a non-bug.

Just because there is a work-around (installing a module or updating settings.php) doesn't mean that this is a non-bug.

Changing the text of a button, whether through hook_form_alter or the theming system, should not break a form's functionality. This issue addresses the fundamentally bad practice of mixing the logic and UI layers.

Count this as my vote for a Drupal-wide fix.

The "String Overrides modul" worked fine for me in Drupal 6.15. I could easily change the "Create new account" text with my own text:)
Thanks for the suggestion Damien. Although it is very annoying that i have to install a module to change the text of a tab!

Any chance this could be revisited?

As mentioned in multiple places around drupal.org, op shouldn't be relied on.
For a good example of this see http://drupal.org/node/144132#op

Also, I have not seen anywhere any doco that says you can use form alter to modify forms, but whatever you do don't modify the text on form submit buttons as it might break your sites functionality.

It just isn't intuitive.

Would this work as a solution or would it cause issues?

bump. i have the same problem. d6

i tried: $form['submit']['#value'] = t('Add company');

user/register works but not admin/user/user/create (it takes me back to list users)

currently using string overrides as a work around...

subscribe. we need to remove this old cruft, though it'll have to be fixed in D8 first.

I would be tempted to remove this line of code:

  $op = isset($_POST['op']) ? $_POST['op'] : $callback_arg;

from user_admin() and just rely on the callback argument. There is only one place in core where this op value seems to be used: openid.module.

I have used a very simple technique using CSS to override create new account button with my custom button image with required text on it. hook_form_alter of course involved in it. just use

if($form_id == 'user_register') {
	$form['submit']['#attributes'] = array('class' => 'create_account');
}

This way i have assigned a new class to create new account button. implement button image into input.create_account class. you can hide create new account / default text in this class.

The 'problem' still persists in d8-dev.
One possible solution for this issue and the rest of modules could be using $form_state['triggering_element']['#name'] that forms module is populating with the clicked button.

To do that:
1. Add a name attribute to all the buttons that needs checking.
2. Change the logic to avoid the use of t() in conditional code.
3. Update tests without language dependence.

Don't know if these changes also affect performance, in a positive way.

New patch with tests updated.

Retesting first #19 patch, updated user.module to add a named to 'Create new account' button.

Included in: http://drupal.org/node/1279688

This appliies and works great on D7.

Great, we definitely need this for Drupal 7. field_group_ajaxified_multipage depends on this patch for some of it's functionality to work.

This is the same patch as #24 but re-rolled for D7.22 and it's working for me.

Let's see if it'll apply against 7.x

#28: 208790_user_admin_28.patch queued for re-testing.

The proposal of this issue is sane. It allows submit buttons to display whatever #value is needed without breaking form submit functionality. It keeps developers from needing to implement additional #validate or #submit handlers to work around the unnecessary use of t().

However, as noted in #4 and #7, this will surely cause issues for numerous d7 sites, given the existing checks of $form_state['values']['op'] == t(), including the core example in drupal_form_submit() to set this value when programatically submitting forms.

So unfortunately, I see no way for this to make it into 7.x core at this point.

This is a bug, so a working patch will probably make it into 8.x (as scor pointed out in #16).

I tested this problem in 8.x and it seems that the problem is fixed.

I used following code in hook_form_alter to change name of the button.

  $default_values = array(
    'id' => 'en',
    'name' => 'English',
    'direction' => 'ltr',
    'weight' => 0,
    'locked' => FALSE,
  );
  $default_language = new \Drupal\Core\Language\LanguageDefault($default_values);
  $translation_manager = new \Drupal\Core\StringTranslation\TranslationManager($default_language);
  $form['actions']['submit']['#value'] = $translation_manager->translate('Test');

The form API changed considerably. The following code is longer an issue on Drupal 8:

function hook_form_alter(&$form, \Drupal\Core\Form\FormStateInterface $form_state, $form_id) {
  $form['actions']['submit']['#value'] = t('Hello world');
}

But I agree with #1 that the language system can be used for this: https://www.drupal.org/docs/7/howtos/change-default-strings-text-without...

Changing to 7.x

Here's a workaround in the meantime.

In a custom module (called custom_user in example below), add:

<?php
/**
 * Implements hook_menu_alter().
 */
function custom_user_menu_alter(&$items) {
  // Override user_admin() for op create.
  $items['admin/people/create']['page callback'] = 'custom_user_admin_create';
}

/**
 * Overrides user_admin() for op create.
 */
function custom_user_admin_create() {
  $build['user_register'] = drupal_get_form('user_register_form');
  return $build;
}
?>

This should solve all this WTF.