Remove remaining references to field_sql_storage

Tagging.

Awesome, @yched++!

+++ b/core/lib/Drupal/Core/Entity/DatabaseStorageController.php
@@ -867,22 +867,22 @@ public function onInstanceDelete(FieldInstanceInterface $instance) {
-    // We need to account for deleted or inactive fields and instances.
-    $instances = field_read_instances(array('entity_type' => $this->entityType, 'bundle' => $bundle_new), array('include_deleted' => TRUE, 'include_inactive' => TRUE));
+    // We need to account for deleted or inactive fields and instances. The
+    // method runs before the instance definitions are updated, so we need to
+    // fetch them using the old bundle name.
+    $instances = field_read_instances(array('entity_type' => $this->entityType, 'bundle' => $bundle), array('include_deleted' => TRUE, 'include_inactive' => TRUE));

Nice, that's why the call below doesn't fail ;)

No test-only patch, but I manually confirmed that the added tests fail without the fix. Changes look great, so I think this is ready to go.

Patch no longer applies.

Patch no longer applies.

1. +++ b/core/modules/editor/lib/Drupal/editor/Tests/EditorFileUsageTest.php
   @@ -19,7 +19,7 @@ class EditorFileUsageTest extends DrupalUnitTestBase {
   +  public static $modules = array('system', 'editor', 'editor_test', 'filter', 'node', 'entity', 'field', 'text', 'file');
   

   The module list in EditorFileUsage test has been shortened in #1605290: Enable entity render caching with cache tag support, so I removed this one from the patch.

2. +++ b/core/modules/node/lib/Drupal/node/Tests/NodeValidationTest.php
   @@ -19,7 +19,7 @@ class NodeValidationTest extends DrupalUnitTestBase {
   +  public static $modules = array('node', 'entity', 'field', 'text', 'filter');
   

   Same here

Rerolled the patch with the changes, so basically nothing changed and still RTBC.

#11: field_sql_storage-2086095-11.patch queued for re-testing.

Should be bot fluke

Committed e40eb19 and pushed to 8.x. Thanks!