Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables
File /core/modules/system/lib/Drupal/system/Tests/Lock/LockFunctionalTest.php
Line 63: Unused local variable $lock_not_acquired_exit
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 2080331-remove-unused-variables-5.patch | 5.42 KB | longwave |
Comments
Comment #1
chertzogCLosed the following as duplicates:
#2080325: Remove Unused local variable $insert_result from /core/modules/system/lib/Drupal/system/Tests/Common/WriteRecordTest.php
#2080327: Remove Unused local variable $description from /core/modules/system/lib/Drupal/system/Tests/Common/AddFeedTest.php
Attached is a patch.
Comment #3
chertzog#1: 2080331-remove-unused-variables.patch queued for re-testing.
Comment #4
areke commentedThe patch doesn't apply. It should be re-rolled.
Comment #5
longwaveComment #7
rfayIt looks to me like #5failed due to a difference in behavior of testbot 959. A different patch came back with the same failures, https://qa.drupal.org/pifr/test/682473
I'd love it if you'd take a look at these fails and see what might be suspect; otherwise you can resubmit and run it on another testbot.
Comment #8
areke commented5: 2080331-remove-unused-variables-5.patch queued for re-testing.
Comment #9
areke commentedThis looks good now.
Comment #10
xjmPlease combine this patch with #2080343: Remove Unused local variables from system module.