Let's start to convert all calls to user_access() with the new AccountInterface::hasPermission() method.

Part of #2048171: [meta] Replace user_access() calls with $account->hasPermission() wherever possible.

Change records for this issue:

CommentFileSizeAuthor
#11 2062017-replace-user_access-calls-11.patch654 bytesdeimos
#9 2062017-replace-user_access-calls-9.patch653 byteswesleydv
#3 2062017-replace-user_access-calls-3.patch637 bytesmichaelhiiva
#1 drupal-rdf_replace_user_access-2062017.patch1.07 KBinternetdevels

Comments

internetdevels’s picture

internetdevels commented
Status: Active » Needs review
StatusFileSize
new drupal-rdf_replace_user_access-2062017.patch1.07 KB

Here is the patch.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work 
+++ b/core/modules/rdf/rdf.module
@@ -244,6 +244,7 @@ function rdf_preprocess_html(&$variables) {
+  $account = Drupal::request()->attributes->get('_account');

https://drupal.org/node/2032447 Drupal:currentUser()

michaelhiiva’s picture

michaelhiiva commented
Status: Needs work » Needs review
StatusFileSize
new 2062017-replace-user_access-calls-3.patch637 bytes
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

great!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Status: Closed (fixed) » Reviewed & tested by the community

Seems that last patch does not commit to core:
http://drupalcode.org/project/drupal.git/blame/HEAD:/core/modules/rdf/rd...

Also I cannot find a commit associated to current issue:
http://drupalcode.org/project/drupal.git?a=search&h=HEAD&st=commit&s=206...

Seems that we need to reopen this issue.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Patch no longer applies.

wesleydv’s picture

wesleydv commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2062017-replace-user_access-calls-9.patch653 bytes

Reroll against head

andypost’s picture

andypost
he/him
Primary language Russian
commented 
+++ b/core/modules/rdf/rdf.module
@@ -333,7 +333,7 @@ function rdf_preprocess_node(&$variables) {
+      if ($variables['page'] && Drupal::currentUser()->hasPermission('access comments')) {

Should be \Drupal::

deimos’s picture

deimos commented
StatusFileSize
new 2062017-replace-user_access-calls-11.patch654 bytes

corrected

wesleydv’s picture

wesleydv commented
Status: Needs review » Reviewed & tested by the community

Looks OK to me.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.