Replace user_access() calls with $account->hasPermission() in forum module

I think the dx of this needs work

We should be injecting the Request into the block plugin here. See https://drupal.org/node/2012118.

+++ b/core/modules/forum/lib/Drupal/forum/Plugin/Block/ForumBlockBase.php
@@ -31,7 +31,7 @@ public function settings() {
+    return \Drupal::request()->attributes->get('_account')->hasPermission('access content');

Use Drupal::currentUser() service https://drupal.org/node/2032447

or probably #2048223: Add $account argument to AccessCheckInterface::access() method and use the current_user service

Lets get #1951268: Convert /forum and /forum/% to new router, remove forum_forum_load(), forum_get_topics(), create Forum service in first (which has been reviewed by @catch, @alexpott, @tim.plunkett, @jibran and @dawehner so must be close)

+++ b/core/modules/forum/lib/Drupal/forum/Plugin/Block/ForumBlockBase.php
@@ -31,7 +31,7 @@ public function settings() {
   public function access() {
-    return user_access('access content');
+    return \Drupal::currentUser()->hasPermission('access content');

Suppose this require new issue to pass $account to access method of blockBase, at least this require proper service injection

The patch doesn't apply, and needs to be re-rolled.

Already fixed