Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views_ui.module
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Aug 2013 at 12:15 UTC
Updated:
28 Sep 2014 at 09:33 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerThere we go.
Comment #3
dawehner#1: vdc-2057427-1.patch queued for re-testing.
Comment #5
dawehner#1: vdc-2057427-1.patch queued for re-testing.
Comment #6
olli commentedTested manually and successfully deleted the frontpage view.
Should we replace this with an assert?
Comment #7
dawehnerGood point.
Comment #9
olli commentedThis should fix it.
Comment #10
olli commentedFew lines below this is:
Is that possible?
Comment #11
dawehnerWhat about checking access via the ViewAccessController ?
Comment #12
olli commentedThat is a good idea.
Comment #13
dawehnerThank you. This is looking great. I guess some screenshots would be cool.
Comment #14
alexpottAs well as screenshots it'b be nice to have an issue summary without a todo :)
Comment #15
damiankloip commentedHere is a screenshot.
The only issue I can see is that if we come to the delete form this way and cancel, we will end back up on the view list page and not the view we were editing.
Comment #15.0
damiankloip commentedadd
Comment #16
dawehnerThank you for the screenshot!
That is not fair ... the original issue summary had a TODO, the current one don't have one anymore. :P
Comment #17
alexpottCommitted 742908a and pushed to 8.x. Thanks!
Comment #18.0
(not verified) commentedblub
Comment #19
alimac commentedRelated: #2179903: fix testDeleteLink() in ViewEditTest with use correct use (not Drupal\views\Plugin\Core\Entity\View) and assertTrue before assertFalse. People familiar with this issue might want to take a look at #2179903.