fix testDeleteLink() in ViewEditTest with use correct use (not Drupal\views\Plugin\Core\Entity\View) and assertTrue before assertFalse

Updated: Comment #1

Problem/Motivation

the "use Drupal\views\Plugin\Core\Entity\View;" statement in Drupal\views_ui\Tests\ViewEditTest is wrong - does not exist.

at the very end of function testDeleteLink() it wants to know what a View is:

    $this->assertFalse($view instanceof View);

it's an accident that this does not fail.
assert false without a corresponding assertion of truth is odd.

likely, earlier in the test, before it deletes the view, something like this:

$view = $this->container->get('entity.manager')->getStorageController('view')->load('test_view');
$this->assertTrue($view instanceof View);

would have picked up that the use statement was wrong.

Proposed resolution

Add the assertTrue and correct the use so that it works.

Remaining tasks

• create a patch (contributor task doc for creating a patch
• think about why it was there (optional, git blame to find out when it was added and add a comment on that issue that this issue is related) #2057427: No delete operation available while editing a view

User interface changes

No

API changes

No

Original report by @alexpott

via irc