Follow up for #1951268: Convert /forum and /forum/% to new router, remove forum_forum_load(), forum_get_topics(), create Forum service

Problem/Motivation

ForumController adds css files individually, ideally this should use a library.

Proposed resolution

Add forum css files to a library and attach them in the controller as such.

Remaining tasks

Write the patch
Review

User interface changes

None

API changes

None

CommentFileSizeAuthor
#3 Screenshot 2013-10-01 07.09.37.png25.47 KBlarowlan
#2 drupal8.forum-module.2028113-2.patch1.53 KBrosk0

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Whoops, tags cloned via dreditor

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Assigned: larowlan » rosk0
Status: Active » Needs review
StatusFileSize
new drupal8.forum-module.2028113-2.patch1.53 KB

Initial patch.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs architectural review, -Entity system, -Platform Initiative, -WSCCI-conversion
StatusFileSize
new Screenshot 2013-10-01 07.09.37.png25.47 KB

Looks fine to me.
Screenshot from manual testing - the forum icons (which are the main intent of that css file) are still present.
Screenshot 2013-10-01 07.09.37.png

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 69a8334 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.