Here we go!
This is the 'princess' patch, which is the entirety of SCOTCH that we've been working on in the 'princess' branch (in this sandbox). We don't have many tests written, and we haven't actually swapped in the use of our display objects for any of the normal Drupal's normal routes - what we have is a test route, which you can see at /booze, that renders through the new method. There's no cheating there - hook_page_build() and hook_page_alter() are never called. You only get to make it onto the page if you are a correctly-participating block. There's also no UI for the new block system. The existing block UI remains in place, so to change things, you have to edit core/profiles/standard/config/display.bound.frontend.yml - that's the display that's used to render the /booze route.
For those concerned about my 'irreverent' naming habits, the only place that "booze" now appears in this code is on this test route, which obviously has no purpose other than being a development-in-progress demo, and thus is not destined for core anyway.
There are lots of new concepts here, and rather than delay this patch further by writing a novel trying to explain everything initially, I'm just gonna leave it at "go poke at it, have fun" for now. We can shape up this issue summary more over the coming days.
Anyone with a better idea for an issue title (or the version) should feel free to change it.
Easiest way for folks to check this out, at least to see the output, would be to pop it over to simpletest.me and go to /booze.
Here is the link to test the latest code in the princess branch Test the princess branch on simplytest.me
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | Screen Shot 2013-06-14 at 7.05.55 AM.png | 45.51 KB | larowlan |
| #2 | scotch-2017681-2.patch | 207.68 KB | sdboyer |
| #1 | scotch-2017681-1.patch | 207.68 KB | sdboyer |
Comments
Comment #1
sdboyer commentedand here's a first patch.
Comment #1.0
sdboyer commentedUpdated issue summary.
Comment #1.1
sdboyer commentedUpdated issue summary.
Comment #2
sdboyer commentedand one with the text on the /booze route all growed-up.
Comment #2.0
sdboyer commentedUpdated issue summary.
Comment #2.1
sdboyer commentedAdded link to sandbox
Comment #2.2
sdboyer commentedUpdated issue summary.
Comment #3
larowlanBTW Choose 8.x on simplytest.me, this applies against 8.x
Comment #4
larowlanbut doesn't work on simplytest.me :(, latest code in princess branch works fine.
To test the latest branch at anytime, use this link
http://simplytest.me/project/1441840/princess?patch[]=https://drupal.org...
Comment #4.0
larowlanUpdated issue summary.
Comment #5
mallezieI assume this issue is for drupal 8 ;-)
Comment #7
swentel commentedLet's keep this to on needs review
Comment #8
larowlanSo to see this with something more tangible give This simplytest.me which is the 2014665-system-main-block branch that includes converting /user/register (view that in an incognito window).
A screenshot to wet your appetite:
Comment #9
eclipsegc commentedComment #10
eclipsegc commentedAdding some tags for easier tracking.
Eclipse
Comment #11
dlu commentedMoved to block.module per #2050763-16: Refine "base system" component (notes on refactoring of "base system" category here: https://docs.google.com/a/acquia.com/spreadsheet/ccc?key=0AusehVccVSq2dF...).
Comment #12
xjmBumping to D9. #2053879: Remove layout.module from core
Comment #13
sdboyer commentedyep...i'm squatting the distro namespace. we'll just have to eat shit for a while longer.
in addition to layouts module, we need to take out displays, as well.
the only other followups i may need, outside of the existing 'happy princess API' tags, is one to make it feasible to disable block module, but still use the block APIs. that might be a bit too much acrobatics, though, in which case i can just focus on disabling it at runtime.
Comment #14
eclipsegc commentedI think the biggest problem with that plan is that BlockManager exists in block module. If we want the api (sans entities) to be available to us, we need to probably move that to a Drupal\Core\Block namespace.
Eclipse
Comment #14.0
eclipsegc commentedupdated issue summary to add simplytest.me link
Comment #15
catchLots of this is getting touched by #2350943: [Meta] Untangle Drupal 8 page rendering in terms of enabling contrib to take over cleanly. Re-classifying.
Comment #16
eclipsegc commentedThere's a lot in this patch, 8.0.0 scotch is in a very good position and this will need serious re-evaluation based upon what's happening in contrib and what has already landed in core. Marking this postponed for the time being. We can look at this again once active 8.1.x development is happening and make a decision at that point.
Eclipse
Comment #19
tim.plunkettNot a part of #2811175: [plan] Add layouts to Drupal, untagging.
Should this just be closed?
Comment #20
eclipsegc commentedI think "yes, it should be closed." Acting accordingly. We'll let someone else un-close it if that become appropriate but I don't foresee that.
Eclipse