Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.While trying doing a config import with Drush I got confused by the mixing of the config_comparer and storage_comparer.
Let's call them the same. Latest patch choose for storage_comparer as that resembles mostly to its class.
Original code from #1890784: Refactor configuration import and sync functions
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedthis seems legit to me.
did you look for any other occurrences of 'storage_comparer'?
Comment #2
clemens.tolboom@beejeebus: good point. Scanning code there where a few more occurrences.
I now have renamed differently to storage_comparer as that resembles more this it's class.
Comment #4
clemens.tolboom#2: core-config_comparer-storage_comparer-2012566-2.patch queued for re-testing.
Comment #5
mtiftTagging
Comment #5.0
mtiftChanged the preferred name from config_comparer to storage_comparer.
Comment #6
Luka Zitnik CreditAttribution: Luka Zitnik commentedTaking on this issue.
commit 0adc91af5c22fedfa74ad1c66cea42a3b6eb5c4e removed /core/modules/config/config.admin.inc, but there are still few $config_comparer variables left for me to rename them to $storage_comparer.
Comment #7
Luka Zitnik CreditAttribution: Luka Zitnik commentedRenamed local variables $config_comparer, instances of \Drupal\Core\Config\StorageComparer, to $storage_comparer.
Comment #9
Luka Zitnik CreditAttribution: Luka Zitnik commented7: core-config_comparer-storage_comparer-2012566-7.patch queued for re-testing.
Comment #10
Luka Zitnik CreditAttribution: Luka Zitnik commentedComment #11
lokapujyaGood change to make the variable name consistent.
Comment #12
alexpottCommitted 77d0c14 and pushed to 8.x. Thanks!