Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is partially a Views issue as well since it also improperly prepares its routes when default tasks are involved.
There is specific code in menu_router_build() to process menu items referencing routes, but it is run before the drupal_alter() call.
Comment | File | Size | Author |
---|---|---|---|
#14 | vdc-2011006-14-FAIL.patch | 3.53 KB | tim.plunkett |
#14 | vdc-2011006-14-FAIL-without-menuinc.patch | 8.24 KB | tim.plunkett |
#14 | vdc-2011006-14-PASS.patch | 10.94 KB | tim.plunkett |
#12 | route-vdc-2011006-12.patch | 7.4 KB | tim.plunkett |
#12 | interdiff.txt | 2.29 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettThis blocks #1895160: Convert admin/content to a View, keep a non-views fallback with no bulk operations and #1851086: Replace admin/people with a View
Comment #2
dawehnerDoes this also cover the case that views_arg is skipped to make it as performant as possible?
What happens with this bits?
Comment #3
tim.plunkettNot sure what you mean about views_args. That's lifted from executeHookMenu().
This covers that now by using &$router_item by reference.
Comment #5
tim.plunkett#1: menu-routes-2011006-1.patch queued for re-testing.
Comment #7
damiankloip CreditAttribution: damiankloip commentedHmm, at the moment this completely kills my installation. Apply this patch and try to install drupal...
Comment #8
tim.plunkettMy silly reference was causing an infinite loop.
Comment #9
dawehnerDon't we need tests for that as well?
Comment #10
tim.plunkettYes. Some module using hook_menu_alter().
Comment #11
damiankloip CreditAttribution: damiankloip commentedSeems like views could do with a test too?
Comment #12
tim.plunkettViews forms are also broken, for the same reason.
This moves the default tab check into a helper method.
The interdiff ignores whitespace.
Still needs tests.
Comment #13
tim.plunkettI can no longer reproduce whatever made me change menu.inc.
I'm going to refocus on writing a test for the views portion.
Comment #14
tim.plunkettActually, the menu.inc change is still needed.
Comment #15
damiankloip CreditAttribution: damiankloip commentedRelated: #2012502: Tab options form cannot be submitted
Comment #16
dawehnerNice!
Comment #17
xjm@tim.plunkett clarified that this is our actual blocker for overriding routes (I couldn't find either of them).
Comment #18
alexpottCommitted edb0095 and pushed to 8.x. Thanks!