Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
base system
Priority:
Minor
Category:
Task
Assigned:
Reporter:
Created:
30 May 2013 at 06:16 UTC
Updated:
29 Jul 2014 at 22:27 UTC
Jump to comment: Most recent file
Follow up for #1331486: Move module_invoke_*() and friends to an Extensions class
https://api.drupal.org/api/drupal/core%21includes%21bootstrap.inc/functi...
is wrong, it says Use drupal_container()->get('module_handler')->moduleExists($hook).
Should be Drupal::moduleHandler()->moduleExists('language')
Update doc.
TBD
No.
No.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 2007684-update-module_exists-doc-and_call-method.patch | 732 bytes | ddrozdik |
| #7 | 2007684-update-module_exist-doc-and_call-method.patch | 685 bytes | ddrozdik |
| #1 | bootstrap.module_exists_depreciated.2007684.1.patch | 551 bytes | yesct |
Comments
Comment #1
yesct commentedthis might not be the right place... as the recommended thing to use does not match what is actually in that function.
Comment #2
tim.plunkettComment #4
ddrozdik commentedWill be done today during Code Sprint UA.
Comment #5
ddrozdik commentedComment #6
podaroktagging
Comment #7
ddrozdik commentedAttached file with changed doc for function. Also I have changed call method inside this function.
Comment #8
ddrozdik commentedBut I think the best way to delete this function from drupal 8 and use Drupal::moduleHandler()->moduleExists('module'); to check exist module or not.
If someone agree with me, I will prepare patch for this.
Comment #9
podarok#7 looks good
if bot`ll happy - RTBC
Comment #10
tim.plunkettDon't we want to update this, not delete it?
Too far indented.
Comment #11
ddrozdik commentedAttached corrected patch.
Comment #12
tim.plunkettThanks!
Comment #13
alexpottNeeds s reroll
Comment #14
ddrozdik commentedThis task already done in Issue #1957154: Replace calls to drupal_container()->get('module_handler') service with Drupal::moduleHandler() and committed to 8.x by webchick here - 30d3671 at 5 june.
Comment #15
ddrozdik commented