Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
| Comment | File | Size | Author |
|---|---|---|---|
| #19 | views-core-rename-sort-options-2003246-19.patch | 1.05 KB | nathangervais |
| #19 | interdiff.txt | 717 bytes | nathangervais |
| #16 | interdiff.txt | 717 bytes | nathangervais |
| #16 | views-core-rename-sort-options-2003246-13.patch | 1.04 KB | nathangervais |
| #14 | views-core-rename-sort-options-2003246-13.patch | 1.04 KB | SpartyDan |
Comments
Comment #1
farfanfelipe commentedComment #2
SlayJay commentedComment #3
SlayJay commentedComment #4
SlayJay commentedComment #5
SlayJay commentedrenamed function names.
Comment #6
SlayJay commentedComment #7
SlayJay commentedforgot to add public.
Comment #8
hozt commentedLooks good.
Comment #10
SlayJay commented#7: 2003246-7449576-2.patch queued for re-testing.
Comment #11
oenie commentedUnfortunately we need a reroll, the patch doesn't apply anymore.
Comment #12
SpartyDan commentedre-rolled
Comment #14
SpartyDan commentedpatch 12 no longer applies.
re-rolled
Comment #15
aspilicious commentedShould be protected
=> protected function sortOptions() {
Comment #16
nathangervais commentedHere's the old patch with an interdiff to add the protected access modifier.
Comment #17
aspilicious commentedPatch odesn't contain the access modifier
Comment #18
dcam commentedIt looks like the same patch from #13 was mistakenly re-uploaded.
Comment #19
nathangervais commentedApologies I had thought i was supposed to supply the original patch with the interdiff. Here's the new patch with the interdiff.
Comment #20
dcam commentedIt's no problem. The interdiff just shows the change you made between the old patch and the new one so that it's easy for reviewers to see the changes that you've made.
Comment #21
dawehnerPerfect!
Comment #22
alexpottCommitted eb60f6f and pushed to 8.x. Thanks!