Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#8 2002980-rename-summary_query.patch3.32 KBsillygwailo
#3 2002980-3-rename_summaryQuery.patch3.25 KBgung wang

Comments

hansenm’s picture

hansenm commented
Assigned: Unassigned » hansenm
gung wang’s picture

gung wang commented
Assigned: hansenm » gung wang

I take this task.

Gang Wang
SUNY Geneseo

gung wang’s picture

gung wang commented
Status: Active » Needs review
StatusFileSize
new 2002980-3-rename_summaryQuery.patch3.25 KB

Uploading patch.

Status: Needs review » Needs work

The last submitted patch, 2002980-3-rename_summaryQuery.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs work » Needs review
aspilicious’s picture

aspilicious commented

All these functions should start with "protected function ...". They are used internally by argument plugins.

oenie’s picture

oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -803,7 +803,7 @@ function default_summary() {
+  function summaryQuery() {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/Formula.phpundefined
@@ -45,7 +45,7 @@ function get_formula() {
+  function summaryQuery() {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ManyToOne.phpundefined
@@ -161,7 +161,7 @@ function title() {
+  function summaryQuery() {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/String.phpundefined
@@ -146,7 +146,7 @@ public function buildOptionsForm(&$form, &$form_state) {
+  function summaryQuery() {

Add protected access modifier in front of the functions to adhere to the new OOP standards.

sillygwailo’s picture

sillygwailo
Location Toronto, ON
commented
Status: Needs work » Needs review
StatusFileSize
new 2002980-rename-summary_query.patch3.32 KB

Re-roll with protected.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2002980-rename-summary_query.patch, failed testing.

sillygwailo’s picture

sillygwailo
Location Toronto, ON
commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#8: 2002980-rename-summary_query.patch queued for re-testing.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed da5a7ff and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.