Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
system.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
13 May 2013 at 15:11 UTC
Updated:
10 Jan 2014 at 20:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
pfrenssenComment #2
pfrenssenAdding tag, this is easy to review :)
Comment #3
johnmcc commentedLooks good, applies cleanly, and the relevant tests still pass.
The only thing I would suggest is that the other asserts in this test breach Drupal's coding standards for function calls. (They have a space between the parenthesis and the first argument.) This should probably be a new ticket though.
Comment #4
pfrenssenYes indeed, I only corrected this in the lines that are relevant to this issue. The others should be fixed in another issue.
If you approve the patch, would you like to mark it as RTBC? :)
Comment #5
johnmcc commentedComment #6
webchickGreat catch!
Committed and pushed to 8.x. Thanks!
Back to 7.x.
Comment #7
johnmcc commentedHere's a backport for 7.x.
Comment #8
pfrenssenLooks good!
Comment #9
David_Rothstein commentedCommitted to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/1f7dc27