Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
quickedit.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
10 May 2013 at 08:43 UTC
Updated:
23 Oct 2015 at 00:53 UTC
Jump to comment: Most recent
Comments
Comment #1
wim leersComment #2
Bojhan commentedLets rename this, so it doesn't sound like polish - which its not. Its essential curves of the car, so to speak - that need to be worked on.
I am going to work on some of the touch up issues, identify what needs work, etc.
Comment #3
wim leersThis is *not* only visual change. cfr. the latency points.
I also added this one:
Comment #4
Bojhan commentedComment #5
wim leersComment #5.0
wim leersAdded #1872296.
Comment #5.1
wim leersUpdated issue summary.
Comment #6
Bojhan commentedOpening this, because I am working on issues around this.
I have added:
#2004284: Integrate "text formats selector" into CKEditor toolbar
Comment #6.0
Bojhan commentedUpdated issue summary.
Comment #7
wim leersThanks! However, #2004284: Integrate "text formats selector" into CKEditor toolbar is hardly related to in-place editing, it's a WYSIWYG thing. That would really belong in a "essential UX cleanup of CKEditor" issue… :) It's fine to keep it here for now though, I'll move it over once we have such an issue.
That being said, we've already solved/closed #1877044: Edit module's JS gets loaded even on admin pages and #1872264: Minimize metadata HTTP requests triggered by Edit's JS by now.
Comment #7.0
wim leersUpdated issue summary.
Comment #8
wim leersUpdate 1: lazy loading as much as possible is impossible without something like AMD in Drupal core, see issue summary.
Update 2: #1872264: Minimize metadata HTTP requests triggered by Edit's JS is implemented by http://drupal.org/project/edit_metadata_cache, but needs two core patches: on #2005644: Use client-side cache tags & caching to eliminate 1 HTTP requests/page for in-place editing metadata, introduce drupalSettings.user.permissionsHash & #1980744-5: Turn edit/metadata into a JsonResponse again, to allow contrib to implement client-side caching of metadata.
Update 3: #1677662: Preload forms to reduce perceived latency to zero is now also closed, similar reasons as #1872264: Minimize metadata HTTP requests triggered by Edit's JS.
Comment #8.0
wim leersUpdated issue summary.
Comment #9
wim leersAdded #1993894: Contextual quick edit toggle should be a <a role="button"> not a <a> because it tracks on/off state.
Comment #10
tkoleary commentedAdded #2022599: "edit mode" toggle in toolbar needs to have text
Comment #10.0
tkoleary commentedUpdated issue summary.
Comment #10.1
tkoleary commentedadded 2022599
Comment #10.2
tkoleary commentedfixed typo
Comment #10.3
wim leersUpdated issue summary.
Comment #11
wim leersAdded #2080217: Polish entity toolbar visually.
Comment #11.0
wim leersUpdated issue summary.
Comment #12
xjmComment #13
tkoleary commentedComment #14
tkoleary commentedComment #15
Bojhan commentedUsing it it doesn't feel very polished. But this issue feels like it can be closed.