CKEditor (should be moved into another issue):

Comments

wim leers’s picture

Title: Finishing touches for Edit module before release » [meta] Finishing touches for Edit module before release
Bojhan’s picture

Title: [meta] Finishing touches for Edit module before release » [meta] Essential visual clean up of Edit inline

Lets rename this, so it doesn't sound like polish - which its not. Its essential curves of the car, so to speak - that need to be worked on.

I am going to work on some of the touch up issues, identify what needs work, etc.

wim leers’s picture

This is *not* only visual change. cfr. the latency points.

I also added this one:

Use D8 core's dialog/modal instead of Edit's own: #1872296: Edit should use core-provided Dialog (instead of its own)

Bojhan’s picture

Title: [meta] Essential visual clean up of Edit inline » [meta] Essential UX cleanup of Edit inline
wim leers’s picture

Title: [meta] Essential UX cleanup of Edit inline » [meta] Essential UX cleanup of Edit
wim leers’s picture

Issue summary: View changes

Added #1872296.

wim leers’s picture

Issue summary: View changes

Updated issue summary.

Bojhan’s picture

Status: Postponed » Active

Opening this, because I am working on issues around this.

I have added:

#2004284: Integrate "text formats selector" into CKEditor toolbar

Bojhan’s picture

Issue summary: View changes

Updated issue summary.

wim leers’s picture

Issue tags: -in-place editing Spark +in-place editing, +Spark

Thanks! However, #2004284: Integrate "text formats selector" into CKEditor toolbar is hardly related to in-place editing, it's a WYSIWYG thing. That would really belong in a "essential UX cleanup of CKEditor" issue… :) It's fine to keep it here for now though, I'll move it over once we have such an issue.

That being said, we've already solved/closed #1877044: Edit module's JS gets loaded even on admin pages and #1872264: Minimize metadata HTTP requests triggered by Edit's JS by now.

wim leers’s picture

Issue summary: View changes

Updated issue summary.

wim leers’s picture

Issue summary: View changes

Updated issue summary.

tkoleary’s picture

tkoleary’s picture

Issue summary: View changes

Updated issue summary.

tkoleary’s picture

Issue summary: View changes

added 2022599

tkoleary’s picture

Issue summary: View changes

fixed typo

wim leers’s picture

Issue summary: View changes

Updated issue summary.

wim leers’s picture

wim leers’s picture

Issue summary: View changes

Updated issue summary.

xjm’s picture

Title: [meta] Essential UX cleanup of Edit » [meta] Essential UX cleanup of Quick Edit
Component: edit.module » quickedit.module
Issue summary: View changes
tkoleary’s picture

Issue summary: View changes
tkoleary’s picture

Issue summary: View changes
Bojhan’s picture

Status: Active » Closed (fixed)

Using it it doesn't feel very polished. But this issue feels like it can be closed.