Convert common_test_js_and_css_querystring() to a new style controller

I'll help!

Try this...

+++ b/core/modules/system/tests/modules/common_test/lib/Drupal/common_test/Controller/CommonTestController.php
@@ -59,4 +59,18 @@ public function typeLinkActiveClass() {
+   * Adds a JavaScript file and a CSS file with a query string appended.
+   */
...
+    drupal_set_title('Test querystring');
...
+    return '';

drupal_set_title can be replaced by return array('#title' => 'Test querystring'); If we do that, just put a @return statement in there as well.

+++ b/core/modules/system/tests/modules/common_test/lib/Drupal/common_test/Controller/CommonTestController.php
@@ -59,4 +59,18 @@ public function typeLinkActiveClass() {
+   * Adds a JavaScript file and a CSS file with a query string appended.
+   */
...
+    drupal_set_title('Test querystring');
...
+    return '';

drupal_set_title can be replaced by return array('#title' => 'Test querystring'); If we do that, just put a @return statement in there as well.

Try this...

+++ b/core/modules/system/tests/modules/common_test/common_test.routing.yml
@@ -4,3 +4,10 @@ common_test_l_active_class:
+  pattern: 'common-test/query-string'

Sorry, pattern should start with "/"

K

Thanks for your work on this issue! Please see #1971384-43: [META] Convert page callbacks to controllers for an update on the routing system conversion process.

Try this...

Try this...

#12: drupal8.system-module.1987656-11.patch queued for re-testing.

#12: drupal8.system-module.1987656-11.patch queued for re-testing.

Straight re-roll of the patch; no interdiff.

+++ b/core/modules/system/tests/modules/common_test/lib/Drupal/common_test/Controller/CommonTestController.php
@@ -73,4 +73,16 @@ public function drupalRenderInvalidKeys() {
+  /**
+   * Adds a JavaScript file and a CSS file with a query string appended.
+   */
+  public function jsAndCssQuerystring() {

Can we have just a simple @return statement, please?

OK...

Thank you very much!!

Committed and pushed to 8.x. Thanks!