Follow up for #1920468: Write tour integration for the first page after install showing extend and other things

Problem/Motivation

If a class or id is not provided for a tip then we should assume that it is a modal.

Proposed resolution

Update javascript tip handling to allow for this consideration.

Here is a screenshot:

Screen Shot 2013-04-29 at 9.25.04 AM.png

CommentFileSizeAuthor
#1 1982008-1-tour-tip-modal.patch624 bytesnick_schuch
Screen Shot 2013-04-29 at 9.25.04 AM.png70.45 KBnick_schuch

Comments

nick_schuch’s picture

nick_schuch commented
Status: Active » Needs review
Issue tags: +JavaScript
StatusFileSize
new 1982008-1-tour-tip-modal.patch624 bytes
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

Assuming bot agrees

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1982008-1-tour-tip-modal.patch, failed testing.

nick_schuch’s picture

nick_schuch commented
Status: Needs work » Needs review

Unrelated fail.

nick_schuch’s picture

nick_schuch commented

#1: 1982008-1-tour-tip-modal.patch queued for re-testing.

nick_schuch’s picture

nick_schuch commented
Status: Needs review » Reviewed & tested by the community

Ok, green. Switching back to RTBC as per #2.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed fcf74af and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.