Free Drupal 7's module_load_include() from is_file() calls

#1: 1978592-1-module_load_include-is_file.patch queued for re-testing.

There is multiple reasons why this is not a duplicate:

• This patch focuses on module_load_include() only, because it's a very small change and can be safely done without being extensive over the system
• Drupal 7 and Drupal 8 are very different, the amalgam cannot be made: other issues have been switched to Drupal 8

Ok spoke too quickly, closing in flavor of #1524630: replace is_file() + require_once() with include_once() for apc performance.

I remebered now why I opened this bug, I was already following the others, and most of them have either been switched to D8, either being closed under other various assumptions. I read them all, I participated in most of them, and I opened this one in order to restrict the field of application of the global idea and make a less extensive, less intrusive although still efficient patch.

#1: 1978592-1-module_load_include-is_file.patch queued for re-testing.

I'm not fond of the @ operator but Drupal always attempt to load non existing files, which is a deeper problem. Thus the operator is mandatory for this very simple patch to work.

Yay green! Please anyone reviews :)

I actually did test the exact opposite, removing this kind of static cache from a few functions in core, and with APC it was quicker without, plus PHP consumed less memory. A decent OPcode cache will already do this static cache for you but at a lower level, and will be faster than you. I'd be curious to know if any is an OPcode cache enabled on your testing box?

1700+ calls

This sound huge! I'd say you have a problem on your site. If you are using a basic commons distribution without modifications, then I'd say Commons has never been designed to perform great.

I will do some benchmarks on my side installing a Drupal commons with Drupal vanilla, my patch and your patch (if I have time on multiple different boxes). Nevertheless I also will try to see why this function is being called so many time, it sounds like a bug to me.

21: 1978592-21-module_load_include-performance.patch queued for re-testing.

This actually works, please I need some reviews here.

I'm not confortable with proceeding with this without profiing a variety of different sites, some more reviews and some benchmarks/profiling traces would be helpful too! Thanks for testing.

I'm definitely not really happy with polluting Drupal with "Yet another static cache" whereas the optimization on that specific include call should be done by the VM or the OPCode, not us. In the other issue, did you do the same benchmarks as those exposed with a single include_once without static cache and without file_exists() ?

"Seem" does not seem legit to me :) I'd be curious to see how it behave both of:
https://www.drupal.org/files/issues/1978592-29-module_load_include-is_fi... (#29)
and https://www.drupal.org/files/1978592-1-module_load_include-is_file.patch (#1)
compared to doing a static cache.

Yes I agree I should probably do some benchmarks myself, will do if I find some time to do it.

@Joelpittet did it, and https://www.drupal.org/node/1443308#comment-10688528 so I close this issue.