Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
CSS
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
30 Jan 2013 at 10:00 UTC
Updated:
29 Jul 2014 at 21:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
echoz commentedComment #3
echoz commented#1: filter-tips-narrow-1902872.patch queued for re-testing.
Comment #4
echoz commentedComment #5
jmarkel commentedIt's not clear to me what the issue actually is. When I added the the padding from the patch to the tips class (via Firebug and/or in Chrome's Developer tools) I didn't see any change, even for very narrow viewports.
Comment #6
echoz commented@jmarkel, I do see it as the screenshots show the before (in issue summary) + after (in #1). There's a browser default 40px margin on a ul. The patch removes it on narrow viewports. Sometimes you need to reload while in the narrow width to see it as it would load narrow.
Comment #7
jmarkel commentedGot it - it wasn't obvious what to look for even when looking at the screenshots, since the text wasn't really mis-aligned at all, there was just too much whitespace to the left (or right on rtl).
Looks good!
Thanks!
Comment #8
catchIs the padding really needed for wider screen sizes?
Comment #9
echoz commented#catch, I figured indented is normal list display, but it will certainly be just as readable either way.
Comment #10
jmarkel commentedAgreed - the padding could certainly be eliminated for all widths but, in the interest of treading lightly with UX changes, perhaps it shouldn't be...
Comment #11
keyhitman commentedComment #12
jmarkel commentedkeyhitman - why are you assigning to yourself? There's a good patch - just a question about whether it should apply for all viewports or only narrow ones. Do you have an opinion on that?
Comment #13
keyhitman commentedFollowing discussion at #10 I reworked the patch to apply to all viewports.
Comment #14
keyhitman commentedAttached screenshots of before and after.
Comment #15
johnalbinThe "More information about text formats" link was also displaying weirdly in the mobile screenshot in the initial summary. Can I get a screenshot for narrow viewports after the patch?
Comment #16
keyhitman commentedFixed the "More Information about text formats" link as per #15. Screenshots are attached

Comment #17
johnalbinThis is exactly the change we need to make. But it adds a left-to-right specific styling. So you need to add a
/* LTR */comment after the declaration and then add the -rtl version to filter.admin-rtl.css.Comment #18
keyhitman commentedHave added -rtl version styling and a /* LTR */ comment as per #17.
Comment #19
johnalbinDrupal.org is pissing me off. I'm uploading the image from the initial posting again, so I can embed it.
[edit: whoops. didn't mean to RTBC it yet.]
Comment #20
johnalbinOk. I've updated the issue summary because I've confirmed that the patch uses the proper solution.
The patch is still in the testing bot queue, but it is a CSS-only fix, so it can't possibly affect any tests. This is RTBC and safe to commit. :-)
Comment #21
webchickWow, that looks much better! RTL support too! :D
Committed and pushed to 8.x. Thanks!
Comment #22.0
(not verified) commentedUpdate issue summary.