Meta Issue:#1870944: [Meta] Mobile friendly admin pages

Problem/Motivation

When viewing node/add pages (node/add/%) in small screens, the text formatter block has misaligned text and excessive padding on its list of text formats.

screenshot of text formatter showing the bugs

Note: the odd wrapping on “More information on text formats” link and the excessive indenting on the bulleted list.

Proposed resolution

Catch suggested that we didn't need the bullet list padding for any viewport sizes (not just a mobile thing.) So we need to remove the padding from the bullet list and also remove the padding from the left side of the more info link.

Remaining tasks

None.

Comments

echoz’s picture

Status: Active » Needs review
StatusFileSize
new35.65 KB
new871 bytes

Status: Needs review » Needs work
Issue tags: -Usability, -mobile, -Responsive Design, -d8mux, -d8mux-admin

The last submitted patch, filter-tips-narrow-1902872.patch, failed testing.

echoz’s picture

Status: Needs work » Needs review
Issue tags: +Usability, +mobile, +Responsive Design, +d8mux, +d8mux-admin

#1: filter-tips-narrow-1902872.patch queued for re-testing.

echoz’s picture

Title: Text formatter alignment in node/add pages, narrow screens » Text format filter tips alignment on narrow screens
jmarkel’s picture

It's not clear to me what the issue actually is. When I added the the padding from the patch to the tips class (via Firebug and/or in Chrome's Developer tools) I didn't see any change, even for very narrow viewports.

echoz’s picture

@jmarkel, I do see it as the screenshots show the before (in issue summary) + after (in #1). There's a browser default 40px margin on a ul. The patch removes it on narrow viewports. Sometimes you need to reload while in the narrow width to see it as it would load narrow.

jmarkel’s picture

Title: Text format filter tips alignment on narrow screens » Tips for Text format filters have excessive left|right padding on narrow screens
Status: Needs review » Reviewed & tested by the community

Got it - it wasn't obvious what to look for even when looking at the screenshots, since the text wasn't really mis-aligned at all, there was just too much whitespace to the left (or right on rtl).

Looks good!

Thanks!

catch’s picture

Status: Reviewed & tested by the community » Needs review

Is the padding really needed for wider screen sizes?

echoz’s picture

#catch, I figured indented is normal list display, but it will certainly be just as readable either way.

jmarkel’s picture

Agreed - the padding could certainly be eliminated for all widths but, in the interest of treading lightly with UX changes, perhaps it shouldn't be...

keyhitman’s picture

Assigned: Unassigned » keyhitman
jmarkel’s picture

keyhitman - why are you assigning to yourself? There's a good patch - just a question about whether it should apply for all viewports or only narrow ones. Do you have an opinion on that?

keyhitman’s picture

StatusFileSize
new733 bytes

Following discussion at #10 I reworked the patch to apply to all viewports.

keyhitman’s picture

Assigned: keyhitman » Unassigned
StatusFileSize
new34.73 KB
new34.81 KB

Attached screenshots of before and after.

Desktop wide - before.png

Desktop wide - after.png

johnalbin’s picture

The "More information about text formats" link was also displaying weirdly in the mobile screenshot in the initial summary. Can I get a screenshot for narrow viewports after the patch?

keyhitman’s picture

StatusFileSize
new13.02 KB
new13.6 KB
new944 bytes

Fixed the "More Information about text formats" link as per #15. Screenshots are attached
more info - before.png

more info - after.png

johnalbin’s picture

Status: Needs review » Needs work
+++ b/core/modules/filter/filter.admin.css
@@ -32,7 +32,7 @@
-  padding: 0 20px;
+  padding: 0 20px 0 0;

This is exactly the change we need to make. But it adds a left-to-right specific styling. So you need to add a /* LTR */ comment after the declaration and then add the -rtl version to filter.admin-rtl.css.

keyhitman’s picture

Status: Needs work » Needs review
StatusFileSize
new981 bytes

Have added -rtl version styling and a /* LTR */ comment as per #17.

johnalbin’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new10.06 KB

Drupal.org is pissing me off. I'm uploading the image from the initial posting again, so I can embed it.

[edit: whoops. didn't mean to RTBC it yet.]

johnalbin’s picture

Ok. I've updated the issue summary because I've confirmed that the patch uses the proper solution.

The patch is still in the testing bot queue, but it is a CSS-only fix, so it can't possibly affect any tests. This is RTBC and safe to commit. :-)

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Wow, that looks much better! RTL support too! :D

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Update issue summary.