Clean up ConfigFactory + ConfigStorageController::save/postsave/rename()

This should definitely happen before release, so bumping to major.

Coming from #1950326: Entity displays are not renamed/deleted when a bundle is renamed/deleted. - I had to manually call the configFactory::rename() method so the internal cache was cleaned up.
Also, when renaming a config entity, the manifest files are not updated.

I agree with what @reyero says in http://drupal.org/node/1187726#comment-6813858 point 3

3. Bad API encapsulation, as the config objects get to "rename themselves" (or delete themselves)

The patch attached moves the rename operation completely to the factory and cleans up it's use in Drupal\Core\Config\Entity\ConfigStorageController. Tests are added for the rename operation in ConfigCRUDTest and ConfigEntityTest

@chx and @xjm pointed out that

+++ b/core/lib/Drupal/Core/Config/Entity/ConfigStorageController.phpundefined
@@ -403,13 +403,25 @@ public function save(EntityInterface $entity) {
+      // Entity id's can contain a dot so we can not use Config::clear() to

Should be // Entity IDs...

As this was a copy&paste job I've fixed it in the original location too...

@chx also queried the empty protected function postSave(EntityInterface $entity, $update) {}... this just the same as preSave(), preDelete() and postDelete()... plus is basest class directly implementing the EntityStorageControllerInterface for Config Entities.

Image styles played up :(... that'll be our nice losely (sic) coupled drupal! @chx :D

Basically it was relying on a full delete being called on the old image style name which would then call image_image_style_delete()... to fix this I've moved all this functionality to an implementation of postDelete() on the ImageStyleStorageController and implemented rename detection in the postSave(). This has the nice side effect of removing code from image.module - and actually image_image_style_update() should move to the ImageStyleStorageController as well - but that is for another patch :)

A comment from @chx on irc made me realise that we can get away with much less change on ImageStyleStorageController and leave the refactor of the image_* entity hooks to #1821848: Move image style load/update/delete operations into a new ImageStyleStorageController.

#8: 1865206.config-rename-cleanup.8.patch queued for re-testing.

The fail of #8 was Drupal\system\Tests\File\StreamWrapperTest... locally passed... and completely unrelated...

#8: 1865206.config-rename-cleanup.8.patch queued for re-testing.

+++ b/core/modules/config/lib/Drupal/config/Tests/ConfigCRUDTest.phpundefined
@@ -87,7 +87,23 @@ function testCRUD() {
+    // Test renaming when config.factory does not have the object in it's static
+    // cache.

AAAAHHHHHHH

http://theoatmeal.com/comics/apostrophe

Boo to me... love the cartoon :)

Committed to 8.x. Thanks.