Patch upcoming.

CommentFileSizeAuthor
#12 1950326-11.patch3.24 KBswentel
#12 interdiff.txt1019 bytesswentel
#10 1950326-9.patch3.28 KBswentel
#10 interdiff.txt2 KBswentel
#8 1950326-8.patch3.08 KBswentel
#8 interdiff.txt1.1 KBswentel
#6 1950326-5.patch3.41 KBswentel
#5 1950326-fail-4.patch1.8 KBswentel
#5 1950326-4.patch3.21 KBswentel
#3 1950326-3.patch1.4 KBswentel
#2 1950326-2.patch1.4 KBswentel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

swentel’s picture

swentel CreditAttribution: swentel commented
Title: Entity displays are not renamed when a bundle is renamed. » Entity displays are not renamed/deleted when a bundle is renamed/deleted.

Better title - patch coming up

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Active » Needs review
FileSize
1950326-2.patch1.4 KB
swentel’s picture

swentel CreditAttribution: swentel commented
FileSize
1950326-3.patch1.4 KB

This is better

yched’s picture

yched CreditAttribution: yched commented

Looks good.

It also shows the absurdity of "entity module has to implement hooks defined by Field API to be aware that an entity bundle was created/renamed/deleted". Totally upside down.

We really need to move field_attach_CUD_bundle() + hooks to entity API. I'll bump #1374116: Move bundle CRUD API out of Field API. Any takers welcome :-/

swentel’s picture

swentel CreditAttribution: swentel commented
FileSize
1950326-4.patch3.21 KB
1950326-fail-4.patch1.8 KB

And now with tests.

swentel’s picture

swentel CreditAttribution: swentel commented
FileSize
1950326-5.patch3.41 KB

This also has a delete test.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs review » Reviewed & tested by the community

Minor: The test doesn't really need to create a field and instance ?

Other than that, this looks RTBC.

swentel’s picture

swentel CreditAttribution: swentel commented
FileSize
interdiff.txt1.1 KB
1950326-8.patch3.08 KB

Right, better patch.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1950326-8.patch, failed testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Reviewed & tested by the community
FileSize
interdiff.txt2 KB
1950326-9.patch3.28 KB

And this is even better, thank you alexpott!

yched’s picture

yched CreditAttribution: yched commented

Better indeed, but another nitpick then :-p

foreach ($entity_display_names as $name) {
was replaced by
foreach ($ids as $id) {
in entity_field_attach_delete_bundle().
+1.

Same thing should be done in entity_field_attach_rename_bundle() for consistency ?

swentel’s picture

swentel CreditAttribution: swentel commented
FileSize
interdiff.txt1019 bytes
1950326-11.patch3.24 KB

Right!

yched’s picture

yched CreditAttribution: yched commented

We're all set then. RTBC it is.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

#12: 1950326-11.patch queued for re-testing.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Issue tags: -Needs tests

Wheee

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed b71bc2c and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.