Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Patch upcoming.
Comment | File | Size | Author |
---|---|---|---|
#12 | 1950326-11.patch | 3.24 KB | swentel |
#12 | interdiff.txt | 1019 bytes | swentel |
#10 | 1950326-9.patch | 3.28 KB | swentel |
#10 | interdiff.txt | 2 KB | swentel |
#8 | 1950326-8.patch | 3.08 KB | swentel |
Comments
Comment #1
swentel CreditAttribution: swentel commentedBetter title - patch coming up
Comment #2
swentel CreditAttribution: swentel commentedComment #3
swentel CreditAttribution: swentel commentedThis is better
Comment #4
yched CreditAttribution: yched commentedLooks good.
It also shows the absurdity of "entity module has to implement hooks defined by Field API to be aware that an entity bundle was created/renamed/deleted". Totally upside down.
We really need to move field_attach_CUD_bundle() + hooks to entity API. I'll bump #1374116: Move bundle CRUD API out of Field API. Any takers welcome :-/
Comment #5
swentel CreditAttribution: swentel commentedAnd now with tests.
Comment #6
swentel CreditAttribution: swentel commentedThis also has a delete test.
Comment #7
yched CreditAttribution: yched commentedMinor: The test doesn't really need to create a field and instance ?
Other than that, this looks RTBC.
Comment #8
swentel CreditAttribution: swentel commentedRight, better patch.
Comment #10
swentel CreditAttribution: swentel commentedAnd this is even better, thank you alexpott!
Comment #11
yched CreditAttribution: yched commentedBetter indeed, but another nitpick then :-p
foreach ($entity_display_names as $name) {
was replaced by
foreach ($ids as $id) {
in entity_field_attach_delete_bundle().
+1.
Same thing should be done in entity_field_attach_rename_bundle() for consistency ?
Comment #12
swentel CreditAttribution: swentel commentedRight!
Comment #13
yched CreditAttribution: yched commentedWe're all set then. RTBC it is.
Comment #14
xjm#12: 1950326-11.patch queued for re-testing.
Comment #15
xjmWheee
Comment #16
alexpottCommitted b71bc2c and pushed to 8.x. Thanks!