Follow up for #1648930-250: Introduce configuration schema and use for translation 14.
Namespace docs standard fix in core/modules/locale/lib/Drupal/locale/StringStorageInterface.php

Problem/Motivation

Originating issue had changes to this file, but only \namespace style fixes. It was cluttering the issue, and needed to be a follow-up.

Proposed resolution

Go through StringStorageInterface.php and fix it to be correct according to http://drupal.org/node/1354#namespaces

Remaining tasks

  • make initial patch of changes, keep focused on only docs and style updates. no refactoring. if refactoring is needed... make it a separate follow-up. :)
  • get review
  • iterate. patch, review.

Test bot coverage should be sufficient. No manual testing or screenshots needed.

User interface changes

no ui changes.

API changes

no api changes.

CommentFileSizeAuthor
#15 StringStorageInterface_docfixes-1852288-15.patch5.07 KBunderq
#13 StringStorageInterface_docfixes-1852288-13.patch4.92 KBunderq
#8 StringStorageInterface_docfixes-1852288-8.patch4.92 KBunderq
#1 StringStorageInterface_docfixes-1852288-1.patch3.67 KBaaronott

Comments

aaronott’s picture

aaronott commented
StatusFileSize
new StringStorageInterface_docfixes-1852288-1.patch3.67 KB

Updated docs based on http://drupal.org/node/1354#namespaces

aaronott’s picture

aaronott commented
Status: Active » Needs review

Status: Needs review » Needs work
Issue tags: -code cleanup, -Novice, -Configuration system, -D8MI, -language-config, -language-config-follow-up

The last submitted patch, StringStorageInterface_docfixes-1852288-1.patch, failed testing.

aaronott’s picture

aaronott commented
Status: Needs work » Needs review
Issue tags: +code cleanup, +Novice, +Configuration system, +D8MI, +language-config, +language-config-follow-up

#1: StringStorageInterface_docfixes-1852288-1.patch queued for re-testing.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

yesct’s picture

yesct commented
Issue tags: -code cleanup, -Novice, -Configuration system, -D8MI, -language-config, -language-config-follow-up

#1: StringStorageInterface_docfixes-1852288-1.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work
Issue tags: +code cleanup, +Novice, +Configuration system, +D8MI, +language-config, +language-config-follow-up

The last submitted patch, StringStorageInterface_docfixes-1852288-1.patch, failed testing.

underq’s picture

underq commented
StatusFileSize
new StringStorageInterface_docfixes-1852288-8.patch4.92 KB

Update patch :)

underq’s picture

underq commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, StringStorageInterface_docfixes-1852288-8.patch, failed testing.

yesct’s picture

yesct commented 
+++ b/core/modules/locale/lib/Drupal/locale/StringStorageInterface.phpundefined
@@ -2,7 +2,7 @@
+ * Contains Drupal\locale\StringStorageInterface.

this should probably be, if this needs to be rerolled again, \Drupal\locale\...
patches are going in without it though.

Drupal\system\Tests\Upgrade\BlockUpgradePathTest fail probably unrelated.

yesct’s picture

yesct commented
Status: Needs work » Needs review

#8: StringStorageInterface_docfixes-1852288-8.patch queued for re-testing.

underq’s picture

underq commented
StatusFileSize
new StringStorageInterface_docfixes-1852288-13.patch4.92 KB

Reroll as suggested by YesCT :)

gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
commented
Status: Needs review » Needs work 
+++ b/core/modules/locale/lib/Drupal/locale/StringStorageInterface.phpundefined
@@ -47,15 +45,15 @@ public function getStrings(array $conditions = array(), array $options = array()
-   *   Array of Drupal\locale\StringInterface objects matching the conditions.
-  */
+   *   Array of translation objects matching the conditions.

It appears we don't have a standard for this, but I actually prefer having the fully qualified object name in the description. Even if we don't make that change, the same object is called a "translation object" here and a "string object" earlier in the patch. It should be consistent.

Otherwise this looks good. Thanks!

underq’s picture

underq commented
Status: Needs work » Needs review
StatusFileSize
new StringStorageInterface_docfixes-1852288-15.patch5.07 KB

I replaced all objects (string, location, translation) with a full qualified object name \Drupal\locale\StringInterface.

I hope this will by ok with you :)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Looks good :) Should not fail since only comment changes.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Component: configuration system » documentation
Assigned: Unassigned » jhodgdon

This is a docs thing, so moving to that component so Jennifer can have a look.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Looks fine, I'll get it committed shortly. Thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: jhodgdon » Unassigned
Status: Reviewed & tested by the community » Fixed

Committed to 8.x -- thanks again!

Automatically closed -- issue fixed for 2 weeks with no activity.