One of our clients had a filtering proxy that returned a message to the effect that the updates.drupal.org server was blocked as its use was unfit for a corporate environment (must be the titillating combination of the words "up", "date" and "release"). Instead of returning a normal error however it was returning a full HTML document -- like every single filtering proxy from a company rhyming with San Francisco I have ever seen --, which made the SimpleXMLParser (with Warnings on) crash with lots of error messages right away and without useful information. So this patch just adds a sanity check to make sure that the returned document is indeed XML and, if for any reason it is not, to display the same error message as if the serverw as unreachable (which is the case).
As the update process no longer crashes at the first check however, modules pulling update information from private URLs will have a chance (hopefully) to get, hm..., full satisfaction.
Comment | File | Size | Author |
---|---|---|---|
#9 | 1847286.9.diff | 513 bytes | thehong |
#6 | update-warning-issue1847286.patch | 617 bytes | pvmchau |
#3 | update.fetch_.inc_.patch | 552 bytes | pvmchau |
update.fetch_.inc_.patch | 449 bytes | MisterSpeed | |
Comments
Comment #1
MisterSpeed CreditAttribution: MisterSpeed commentedTo test the old behaviour just temporarily add this at line 158 in update.fetch.inc:
$data = '<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN"><html><head></head><body></body></html>';
Comment #3
pvmchau CreditAttribution: pvmchau commentedThe new patch with fixing in #1
Comment #4
pvmchau CreditAttribution: pvmchau commentedupdate.fetch_.inc_.patch queued for re-testing.
Comment #6
pvmchau CreditAttribution: pvmchau commentedRe-upload patch in #3 with right format.
Comment #7
MisterSpeed CreditAttribution: MisterSpeed commentedForcing the status change
Comment #9
thehong CreditAttribution: thehong commentedUp!
Comment #10
mgiffordPatch still applies which is great.