In the setUp function of WebTestBase class of the simple test module, I found that $language_interface variable isn't being used. We should remove it.

CommentFileSizeAuthor
#6 1788588-remove_unused_variables_webtestcase-6.patch650 bytespcambra
#1 1788588-remove_unused_variables_webtestcase-1.patch944 bytespcambra

Comments

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new 1788588-remove_unused_variables_webtestcase-1.patch944 bytes

They don't seem to be used, let's see what the testbot thinks

bleen’s picture

bleen commented
Status: Needs review » Reviewed & tested by the community

looks good

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

Patch no longer applies. Moving to needs work and applying for a re-test just in case.

dries’s picture

dries commented
Status: Needs work » Needs review
Issue tags: -Novice

#1: 1788588-remove_unused_variables_webtestcase-1.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice

The last submitted patch, 1788588-remove_unused_variables_webtestcase-1.patch, failed testing.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Needs work » Needs review
StatusFileSize
new 1788588-remove_unused_variables_webtestcase-6.patch650 bytes

It seems that the second reference to the unused variable was removed somewhere else.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Yes, let's remove this. Tests would have failed if it would be used anywhere or have a side effect that's required.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks for the quick reroll.

Automatically closed -- issue fixed for 2 weeks with no activity.