Let Primary and Secondary links be arbitrary menus as in the Drupal 5 menu system

Patch please.

• Implemented the selection of primary and secondary links
• If primary links == secondary links, the secondary links now display the second level of primary tabs

I did not add the “Show all menus” item because at the moment, it does not really make sense to select anything here.
Users can’t create menu items otf when they don’t have “administer menu” and if they have, they can see all menus anyway.

Changes as per pwolanin on IRC: Don’t modify menu_tree_page_data() and implement the logic in menu_primary_links() and menu_secondary_links().

Cleaned up patch with pwolanin's help. Added some documentation.

Loop is more legible now.

Not being able to cache the navigation block is not a show-stopper for this patch and is something we could work on in a follow-up patch. The only way to solve this is by providing a setting in the navigation block's configuration page, or to create a contributed module that alters the cache-field in the blocks table.
That or you could edit one line of code. Let's focus on what we have now, and then consider another iteration of improvements. I don't think these improvements will change the API -- they'd merely add configuration settings.
(mis-posted)

per conversation with Dries - make this a theme setting, not a menu module setting.

note, the patch also includes the single-line patch that is here: http://drupal.org/node/166491 so that the global theme settings are useable.

Changed some strings. Functionality-wise it works correct.

IMO, these are not decisions to be made by the theme layer.

Everything we're talking about is choosing what to present: Choosing which menu should be primary and secondary, etc. That is not the presentation layer, that is logic.

The theme layer should only choose HOW to present the data it's given. It should not be selecting data sources. The biggest choice about the data it should be making is whether or not to present data it is given, and how to present it.

This should remain a menu setting.

Per Merlin's suggestion, as compared to the previous patch, the only setting as to *which* content to use is done in menu module. The theme system has options only to toggle the primary and secondary links on or off.

fix typo and re-roll for this commit: http://drupal.org/node/166491

make the title reflect the patch.

Still applies, tested it successfully. This is RTBC, we need this in D6.

Is it a current/suggested practice to use "(Optional)" no optional parameters, in parenthesis and not as a leading "Optional ..." word in the sentence?

re-rolled without parentheses around Optional.

Ok, looks fine. Committed, thanks!

Errr... what happened to "ability to set primary and secondary links to arbitrary menus"? That was in the first few versions of this patch, but it seems to have disappeared around #12. Could we put that back, please?

We should also remove the new "Source for the secondary links" option. How did that sneak in? I don't see any discussion about it in this issue. Anyway, it's not as flexible as actually setting the menu for the secondary links, so I see it as a step backward. Let's get rid of it, and put the old options back, which weren't so limiting.

I also created http://drupal.org/node/170322 (having 'proper' menus for books) which is related to this issue.

@Jaza - well, the KISS principle suggests that assigning arbitrary menus to Primary/Secondary is not really needed.

What's the burning, common use case?

@pwolanin: see http://drupal.org/node/170322 for a use case (not 'burning', I admit, but it's there).

@Jaza - that issue seems somewhat orthogonal, unless you are saying that you want a book to be your primary links?

in the absence of a compelling use case from Jaza, I'm satisfied with what we have already.

Hi.
if you set "source for secondary links = primary links" and activate the "secondary links box" you get an empty box because links from the menu called "secondary-links" are shown.

I changed the following in function menu_block($op, $delta) to get it working:

  else if ($op == 'view') {
    $data['subject'] = check_plain($menus[$delta]);
    if ($delta == 'secondary-links' && variable_get('menu_secondary_links_source', 'secondary-links') == 'primary-links') {
      $tree = menu_tree_page_data('primary-links');
      foreach ($tree as $link_data) {
        if ($link_data['link']['in_active_trail']) {
          $data['content'] = menu_tree_output($link_data['below']);
          break;
        }
      }
    }
    else {
      $data['content'] = menu_tree($delta);
    }
  return $data;
}

hope this is the right place. i'm not sure if it is the right way to do....

@markus-v-drupal: this should not be part of this issue. A new issue is here: http://drupal.org/node/180786 please post follow-ups there.

@Boris: I still don't think assigning arbitrary menus is a good idea. I'd be much more supportive of adding utility function/admin page to allow two menus to be swapped. Or that could be a contrib module.

This was fixed in 6.x as a result of http://drupal.org/node/216813