Because it calls node_show with wrong parameters. Notice how arg(2) is made sure to be revisions in the beginning of node_show and watch that string passed as $cid... Research makes it likely that Gerhard copy-pasted this in his great revision patch from the normal page view and then passed unnoticed and now that it lives in a separate function it looks even more interesting.

In 4.7 , too (this is verified by Zen).

CommentFileSizeAuthor
#4 node_show.patch.txt1.14 KBkilles@www.drop.org
#3 node_show_revision.patch669 byteschx
#1 node_show_revision.patch_0.txt666 byteschx
node_show_revision.patch.txt1.33 KBchx

Comments

chx’s picture

chx commented
Assigned: Unassigned » chx
StatusFileSize
new node_show_revision.patch_0.txt666 bytes
webernet’s picture

webernet commented
Title: revision view displays no comments » Revision view displays no comments

Possibly related to: http://drupal.org/node/100836

chx’s picture

chx commented
StatusFileSize
new node_show_revision.patch669 bytes

Not related. But, node_show has no default for $cid so... (thanks Zen)

killes@www.drop.org’s picture

killes@www.drop.org commented
StatusFileSize
new node_show.patch.txt1.14 KB

I think I prefer this patch.

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

I would as well but very strictly speaking this is an API change. However, it is backwards compatible. Both #3 and #4 are ready to go and I leave it to the powers above us to decide which gets in.

My 2c is on #4.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

The last patch works for me, but let's take the opportunity to improve the phpdoc a bit.

ricabrantes’s picture

ricabrantes commented

This bug are fixed in D6.x-dev.. But still active in D5.x-dev..

dpearcefl’s picture

dpearcefl commented
Status: Needs work » Closed (won't fix)

Considering the time elapsed between now and the last comment plus the fact that D5 is no longer supported, I am closing this ticket.