Problem/Motivation
The dropzonejs module declares the DropzoneJS library license URL as
https://github.com/enyo/dropzone/blob/master/LICENSE in
dropzonejs.libraries.yml. The upstream DropzoneJS project has moved from
enyo/dropzone to dropzone/dropzone and renamed its default branch
from master to main. As a result, the old license URL now returns a
Redirect
Steps to reproduce
- Install the
dropzonejsmodule. - Open
dropzonejs.libraries.yml(or view the library license link). - Follow the license URL
https://github.com/enyo/dropzone/blob/master/LICENSE. - Observe that GitHub returns to the new URL, lets just alter it with the new url instead.
Proposed resolution
Update the license URL in dropzonejs.libraries.yml to the new upstream location:
license: name: MIT - url: https://github.com/enyo/dropzone/blob/master/LICENSE + url: https://github.com/dropzone/dropzone/blob/main/LICENSE gpl-compatible: true
Remaining tasks
- Review and commit the patch.
User interface changes
None (the displayed license link now resolves correctly instead of 404).
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|
Issue fork dropzonejs-3619000
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
remco hoeneveld commentedComment #3
remco hoeneveld commentedComment #5
damienmckennaComment #6
damienmckennaThank you for opening the issue and creating a MR; for anyone else reviewing this, the patch didn't cover enough details, so shouldn't be reviewed.
This isn't really a bug as something changed elsewhere, it's more of a task.
Everything looks good, so I think this should be committed as-is.