Problem/Motivation

PHP 8.4 deprecated implicitly nullable typed parameters — when a parameter has a typed declaration but a default value of `NULL` without the explicit `?` prefix. PHP 8.5 continues to emit the deprecation notice on every request where the affected code path is executed.

The following method in `src/Plugin/migrate/destination/DraggableViews.php` triggers this deprecation:

public function fields(MigrationInterface $migration = NULL) {

Proposed resolution

Add the explicit `?` nullable prefix:

public function fields(?MigrationInterface $migration = NULL) {

Remaining tasks

TBD

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#4 draggableviews_php85_implicit_nullable_4.patch951 bytesmauriciopieper
#2 draggableviews_php85_implicit_nullable.patch416 bytesmauriciopieper

Comments

mauriciopieper created an issue. See original summary.

mauriciopieper’s picture

mauriciopieper commented
StatusFileSize
new draggableviews_php85_implicit_nullable.patch416 bytes
phily’s picture

phily
he/him
Primary language French
Location 🇪🇺🇫🇷 Paris, France
commented
Status: Active » Needs review

Thanks.
No need for MR as it seems already fixed in 2.1.x-dev release.

mauriciopieper’s picture

mauriciopieper commented
StatusFileSize
new draggableviews_php85_implicit_nullable_4.patch951 bytes

Attaching a new patch because I missed another implicit nullable parameter.