Deprecation warning appears when used with PHP 7.2:

Deprecated function: The each() function is deprecated. This message will be suppressed on further calls in draggableviews_preprocess_views_view_table() (line 101 of modules/contrib/draggableviews/draggableviews.module).

CommentFileSizeAuthor
#7 php72_each_3056373.7.patch1.31 KBsocketwench

Comments

Daniel Kulbe created an issue. See original summary.

daniel kulbe’s picture

daniel kulbe
he/him
Primary language German
Location Berlin
commented
Version: 8.x-1.x-dev » 8.x-1.2
daniel kulbe’s picture

daniel kulbe
he/him
Primary language German
Location Berlin
commented
Status: Active » Closed (duplicate)
tengoku’s picture

tengoku
Primary language Spanish
Location Bogotá
commented

sorry. came from google.. which is the original issue?

frosty29’s picture

frosty29 commented

I don't think is a duplicate? Daniel Kulbe maybe thought it was referring to the fix for each() here https://www.drupal.org/project/draggableviews/issues/3013512. There is still an each() call on line 101 of draggableviews.module
// Set the first column.
$first_column = each($columns);

frosty29’s picture

frosty29 commented
Status: Closed (duplicate) » Active
socketwench’s picture

socketwench commented
Status: Active » Needs review
StatusFileSize
new php72_each_3056373.7.patch1.31 KB

This looks like it works?

socketwench’s picture

socketwench commented

Ahhh, this looks like it might already be fixed in the dev version. Thus explaining the funny diff. Also, I'm very tired.

socketwench’s picture

socketwench commented
Status: Needs review » Closed (outdated)