When running PHP5.4 the output of view is "Array" instead of table with draggable rows. Alse there is no submit button.

CommentFileSizeAuthor
#3 draggableviews_theme.inc_.patch610 bytesRStrydom

Comments

istryker’s picture

istryker commented
Priority: Major » Minor

Drupal does not support PHP 5.4 yet. Changing the priority

NaX’s picture

NaX commented
Component: User interface » Code
Priority: Minor » Normal

This is a big deal to me so I did some digging. After a frustrating few hours of stepping through code I changed one character in draggableviews_theme.inc and it started working.

From:

function template_preprocess_draggableviews_view_draggabletable_form($vars) {
}

To:

function template_preprocess_draggableviews_view_draggabletable_form(&$vars) {
}

It looks like the reference & was missing.

RStrydom’s picture

RStrydom commented
Status: Active » Needs review
StatusFileSize
new draggableviews_theme.inc_.patch610 bytes

#2 Fix worked for me.

Attached re-rolled as patch -- built against DraggableViews 6.x-3.5 tested with views 6.x-2.16

faboulaws’s picture

faboulaws commented
Status: Needs review » Fixed

Thank you for posting.I had the same issue and guess what ?you are a saviour. You should know that the frustrating few hours you have spent is helping other people.

NaX’s picture

NaX commented
Priority: Normal » Major
Status: Fixed » Reviewed & tested by the community

@faboulaws
Thanks for the words of encouragement. I think we would should let the project maintainer decide when the issue is considered committed and fixed.

Considering this completely prevents the usage of the module in a newer PHP version I am bumping the Priority back to major. The longer we leave PHP incompatibilities like this the bigger the problem becomes with more installations being setup with code that will through errors and break.

Drupal 6: PHP 4.4.0 or higher (5.2 recommended).
Drupal 7: PHP 5.2.5 or higher (5.3 recommended).
Drupal 8: PHP 5.3.10 or higher.

Ref: http://drupal.org/requirements

istryker’s picture

istryker commented
Status: Reviewed & tested by the community » Fixed

Committed b0d93f9 to 6.x-3.x-dev. Does this effect 7.x-2.x?

NaX’s picture

NaX commented

Great thanks.
I had a look and I cant find the same problem in 7.x-2.x. I think it only affects 6.x.

Do you think this kind of problem deserves rolling a new release?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.