When the doorman module is enabled (drup 7.22), putting the site in maintenance mode has no effect, although Drupal reports that the site has been put in maintenance mode successfully. It's a small issue, but could turn nasty if a developer fails to test if his/her site has indeed been put in maintenance-mode.

Comments

manarth’s picture

manarth commented
Issue summary: View changes

If both maintenance-mode and Doorman are enabled, it can be a little confusing to choose which should take precedence.

Doorman's primary concern is whether the user is logged in.
Maintenance-mode's concern is whether a user has the permission "access site in maintenance mode", which could theoretically be assigned to the anonymous user.

There is therefore an edge-case, where the anonymous user can use the site in maintenance mode, but Doorman should still restrict access.

Currently, from a security perspective, access is still restricted, but instead of seeing a maintenance message, affected users are redirected to the login page. I agree we should change this, so that - with the exception of this edge case - maintenance mode rules take precedence, so that visitors see the relevant maintenance-mode message.

  • manarth committed 9fb11d6 on 7.x-1.x 
    Issue #2074879: module interferes with maintenance-mode
manarth’s picture

manarth commented
Status: Active » Fixed

F

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.