Meta issue:#1798318: Forums

Problem:
The "Post new Forum topic" link was not found

Example Page/s:
http://git7site.devdrupal.org/forum

Test output:
Multiple Scenarios were effected

@forums
Feature:
In order to restrict unauthorized users from uploading files while creating a Forum Topic
As a site admin
I need to know that file upload is only permitted to users with Administer content.

Scenario: Check File Attachments is not available for site user # features/drupalorg/forum_file_uploads.feature:7
Given I am logged in as "site user" # FeatureContext::iAmLoggedInAs()
When I follow "Support" # FeatureContext::clickLink()
And I follow "Forums" # FeatureContext::clickLink()
And I follow "Post new Forum topic" # FeatureContext::clickLink()
Link with id|title|alt|text "Post new Forum topic" not found.
Then I should not see "File attachments" # FeatureContext::assertPageNotContainsText()
And I should not see "Attach new file:" # FeatureContext::assertPageNotContainsText()

Screenshot:
http://awesomescreenshot.com/0d3hk1hd1

Comments

alexpulido’s picture

alexpulido commented
Title: Forums - Link with id|title|alt|text "Post new Forum topic" not found. » Forums - Link "Post new Forum topic" not found.

changing title

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Active » Postponed

I filed an issue for the underlying cause, #1802656: Add D7 $action_links to page.tpl.php.

D7 changed the copy with #523406: Cleanup forum description; it will be "Add new Forum topic" when it appears.

rupl’s picture

rupl
he/him
Primary language English
commented
Status: Postponed » Needs review

I've committed the fix for #1802656: Add D7 $action_links to page.tpl.php so we need to revisit this test when the staging site is updated.

eliza411’s picture

eliza411 commented

I don't have a way to confirm that this particular commit has been incorporated, but as of today,

Anon:

 Log in to post new content in the forum.

Auth: 

 You are not allowed to post new content in the forum.

And an admin sees:

Add new Forum topic

so I think it's wrapped in but the auth privileges may not be defined properly.

eliza411’s picture

eliza411 commented
Status: Needs review » Needs work

Verified the missing permission http://awesomescreenshot.com/004ihlse4 - not sure who sets that.

eliza411’s picture

eliza411 commented
Title: Forums - Link "Post new Forum topic" not found. » Forums - Link "Add new Forum topic" not found.

Updating title to match the new language on the D7 site. Feature files have been updated to match changes.

senpai’s picture

senpai commented
Assigned: Unassigned » sdboyer
Status: Needs work » Active
Issue tags: +BDD

@sdboyer will fix this missing link issue today, and then kick it back to 'needs review'.

sdboyer’s picture

sdboyer commented
Assigned: sdboyer » Unassigned
Status: Active » Fixed
Issue tags: -BDD

yeah, that needs to be added to the set of permissions remappings. i've pushed that fix to drupalorg, and in the meantime manually made the change on git7.

now it's failing on a later step - checking that the form field is outlined in red, then again later on finding the 'Subject' field.

not sure if this should be marked fixed or not for those issues, but i'm keeping with the strict scope defined by the title, which has now been fixed. so marking fixed. :)

sdboyer’s picture

sdboyer commented
Status: Fixed » Needs review
Issue tags: +drupal.org D7, +BDD

sorry, xpost. unassigning from myself, and following Senpai's status guideline.

eliza411’s picture

eliza411 commented
Status: Needs review » Fixed

Add new Forum topic is fixed - marking as such. Other issues will be addressed separately.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

removing irrelevant background statement