Review of the 8.x-1.x branch (commit 7d1496b):
README.md or README.txt is missing, see the guidelines for in-project documentation.
The domain_registration.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
DrupalPractice has found some issues with your code, but could be false positives.

FILE: ...or/drupal/pareviewsh/pareview_temp/src/DomainRegistrationPattern.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
34 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
--------------------------------------------------------------------------

FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/domain_registration.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
8 | WARNING | Global constants should not be used, move it to a class or
| | interface
9 | WARNING | Global constants should not be used, move it to a class or
| | interface
--------------------------------------------------------------------------

Time: 987ms; Memory: 4Mb
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...drupal/pareviewsh/pareview_temp/src/Tests/DomainRegistrationTest.php
--------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
--------------------------------------------------------------------------
5 | ERROR | [x] When importing a class with "use", do not include a
| | leading \
14 | ERROR | [x] Short array syntax must be used to define arrays
24 | ERROR | [x] Short array syntax must be used to define arrays
41 | ERROR | [x] Short array syntax must be used to define arrays
58 | ERROR | [x] Short array syntax must be used to define arrays
75 | ERROR | [x] Short array syntax must be used to define arrays
92 | ERROR | [x] Short array syntax must be used to define arrays
109 | ERROR | [x] Short array syntax must be used to define arrays
127 | ERROR | [x] Short array syntax must be used to define arrays
144 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...al/pareviewsh/pareview_temp/src/Form/DomainRegistrationAdminForm.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
65 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/domain_registration.module
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
66 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 843ms; Memory: 4Mb

CommentFileSizeAuthor
#2 3109427-2.patch8.2 KBankush_03

Comments

ankush_03’s picture

Status: Active » Needs review
StatusFileSize
new8.2 KB

Adding patch !

pcambra’s picture

Title: Drupal Coding Standarad issues » Drupal Coding Standard issues

pcambra’s picture

Status: Needs review » Fixed

Pushed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.