As content editor / developer, we are not able to identified revision id on revision form.. so we needed the revision id on the revision form/Motivation

Steps to reproduce

Goto any content node -> select revision tab ->check the revisions

Proposed resolution

Add revision id to the revision form

Example:
Any below example:
form contains information about date-time and user name with revision message, but for better understanding we required date-time; revision id and user name with revision message
current form looks like:

current-fom

proposed form will look like:

proposed-form

CommentFileSizeAuthor
#13 after.png83.61 KBrajdip_755
#13 before.png74.37 KBrajdip_755
#7 Screenshot 2023-04-17 at 5.48.40 AM.png36.65 KBblanca.esqueda
#7 diff-display_revision_id-3338468-7.patch2.82 KBblanca.esqueda
#5 3338468-5.patch1004 bytesmayurgajar
#3 Screenshot 2023-02-02 at 10.56.07 AM.png168.92 KBmayurgajar
Screenshot 2023-02-02 at 10.49.21 AM.png162.4 KBmayurgajar

Issue fork diff-3338468

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mayurgajar created an issue. See original summary.

mayurgajar’s picture

mayurgajar commented
Issue summary: View changes
mayurgajar’s picture

mayurgajar commented
StatusFileSize
new Screenshot 2023-02-02 at 10.56.07 AM.png168.92 KB

Proposed form looks like:
added below image:

mayurgajar’s picture

mayurgajar commented
Issue summary: View changes
mayurgajar’s picture

mayurgajar commented
StatusFileSize
new 3338468-5.patch1004 bytes

Added patch for this feature request.

Along with date, we now able to see the revision id on the rows.

mayurgajar’s picture

mayurgajar commented
Assigned: mayurgajar » Unassigned
Status: Active » Needs review
blanca.esqueda’s picture

blanca.esqueda commented
StatusFileSize
new diff-display_revision_id-3338468-7.patch2.82 KB
new Screenshot 2023-04-17 at 5.48.40 AM.png36.65 KB

Addressed the same thing but having revision id in it's own columns similar as D7
Please find the patch attached, also moved the diff button at the top.

Status: Needs review » Needs work

The last submitted patch, 7: diff-display_revision_id-3338468-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

silvi.addweb made their first commit to this issue’s fork.

silvi.addweb opened merge request !67

silvi.addweb’s picture

silvi.addweb commented
Status: Needs work » Needs review

Raised MR for the same.

acbramley changed the visibility of the branch 8.x-1.x to hidden.

rajdip_755’s picture

rajdip_755
Primary language Bengali
Location kolkata
commented
StatusFileSize
new before.png74.37 KB
new after.png83.61 KB

Hi @silvi.addweb, I have tried to applied your MR as a patch to the latest version of the module v1.7.0 . It's successfully added the revison ID in the table. But can you explain what is the need to add the following lines.

if ($revision_count > 1) {
      $build['submit'] = array(
        '#type' => 'submit',
        '#button_type' => 'primary',
        '#value' => t('Compare selected revisions'),
        '#attributes' => array(
          'class' => array(
            'diff-button',
          ),
        ),
      );
    }

For this changes the Compare selected revisions button are coming twice side by side, which is not looking good. In the latest versions of this module there is a feature to show this button at the top of the table if there are more than 5 revisions. So that I think we should not add these lines in this PR.

I'm attaching here the screenshot of the UI before and after applying the changes of the MR.

Thanks !

rajdip_755’s picture

rajdip_755
Primary language Bengali
Location kolkata
commented
Status: Needs review » Needs work
rajdip_755’s picture

rajdip_755
Primary language Bengali
Location kolkata
commented

Hi, @silvi.addweb, could you please look into #13? If the requested changes seem feasible, we can proceed with them.