Problem/Motivation

When trying to moderate on an item that only has 1 draft and nothing to diff, the system loops and WSOD, and fills the log with notices about missing $revision_ids[ (id) ]

Steps to reproduce

For my instance it was just - moderate a single draft of a normal content type.

Proposed resolution

I changed

// If there are only 2 revision return an empty row.
if ($revisions_count == 2) {
return [];
}

// If there are less-than 2 revision return an empty row.
if ($revisions_count <= 2) {

Comments

devitate created an issue. See original summary.

devitate’s picture

StatusFileSize
new3.56 KB
recrit’s picture

See related bug #3033455: 500 error: Possible infinite loop that may fix this issue as well.

recrit’s picture

heddn’s picture

For this to be reviewed and accepted, please review https://git.drupalcode.org/project/diff#contribution-guidelines. Since this is an older contribution, it could need a reroll/rebase. Additionally, we'll need an MR opened and some tests.

acbramley’s picture

Status: Needs review » Postponed (maintainer needs more info)

Can you please retest on the latest 2.x dev release

acbramley’s picture

Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

I am unable to reproduce this issue.

If you are able to still reproduce this on the 2.x branch on Drupal 11, please feel free to reopen this issue with steps to reproduce.