Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Head is failing in DiffRevisionTest::doTestOverviewPager
and DiffPluginTest::doTestFieldWithNoPlugin
Proposed resolution
Fix head test failing.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#13 | 2887598-13.patch | 23.51 KB | jhedstrom |
Comments
Comment #2
toncic CreditAttribution: toncic at MD Systems GmbH commentedThere is still one test fail in
DiffRevisionTest::doTestOverviewPager
.After creating 11 revisions:
On first revision page we should see 10 revision but there is not any revision:
Any idea what is going on here?
Comment #3
toncic CreditAttribution: toncic at MD Systems GmbH commentedComment #5
Alan D. CreditAttribution: Alan D. commentedFailing tests isn't good, particularly if blocking other important issues.
Before retesting;
I've queued the 4 PHP 5.5 tests with against all Drupal 8.x branches and added PHP 7 test against D8 default branch (currently 4.x).
https://www.drupal.org/node/20492/qa
It is likely that you'll need to add a lot of verbose debugging in the tests locally to actually see what is being produced in each step to figure out what is happening here.
Comment #6
Alan D. CreditAttribution: Alan D. commentedNot so good.
PHP 5.5 & MySQL 5.5, D8.1 38 pass, 9 fail
PHP 5.5 & MySQL 5.5, D8.2 45 pass, 1 fail
-- I believe Miro (miro_dietiker) only cares about supported core releases, so these can be ignored.
PHP 5.5 & MySQL 5.5, D8.3 43 pass, 3 fail
https://www.drupal.org/pift-ci-job/702812
PHP 5.5 & MySQL 5.5, D8.4 24 pass, 24 fail
PHP 7 & MySQL 5.5, D8.4 24 pass, 24 fail
https://www.drupal.org/pift-ci-job/702809
Comment #7
johnchqueTo keep the tests passing on in previous versions of core, we need to implement something like in #2887759: Update tests with the recent changes.
Comment #8
jhedstromAlso failing in
DiffRevisionTest::doTestRevisionDiffOverview
in 8.4 due to #2068063: Change "Save and keep un-/published" buttons to a "Published" checkbox and an included "Save" button, so the button 'Save and publish' is no longer found.Comment #9
jhedstromI'll see if I can get these passing.
Comment #10
jhedstromThis has the same failure as in #2, but fixes tests for 8.4 using a similar approach to #2068063: Change "Save and keep un-/published" buttons to a "Published" checkbox and an included "Save" button.
I'll take a look at the remaining fail tomorrow if I get a chance.
Comment #11
jhedstromOops, I forgot to add the new trait to the patch above.
Comment #12
jhedstromSo the remaining failure, where the first page of revisions is empty, for some reason this line (in
RevisionOverviewForm::buildForm()
) is returning false (specifically, theisRevisionTranslationAffected()
bit), and thus the row is not built.Comment #13
jhedstromIt seems that
isRevisionTranslationAffected
checks to see if anything actually changed, so this fixes the test by changing the value of the body field.Comment #14
Alan D. CreditAttribution: Alan D. commentedNice work, this looks good to me.
Comment #16
Alan D. CreditAttribution: Alan D. commentedPushed since the D8 guys must be busy atm. There are a couple other major issues are getting held up with this one :)
Thanks!