Array to string conversion in Drupal\diff\Plugin\diff\Field\ImageFieldBuilder->build()

The problem lies in the fact that the line "implode ($separator, $result[$field_key])" may as $separator arrive array and function will not work. Check it please.

@dhendriks:
From which Diff version did you update?

Discussed this with @Berdir.
We don't see how that update could have caused this bug. None of the relevant code has been changed.

If you want, you can share your configuration file. That should make clear what's corrupted.
(admin/config/development/configuration/single/export: "Simple configuration" and "diff.plugins". You are looking for property_separator in the output. In a valid configuration, the value has to be a string, e.g., property_separator: 'nl'.)

You can then fix that manually in admin/config/content/diff/fields.
(Find the relevant item(s) in the list. Open its drop-down options. Set "Property separator" to whatever you want. Click "Update". Click "Save".)

Instead, you can also run this piece of code:

$result = [];
$root =  \Drupal::configFactory()->get('diff.plugins')->get('fields');
foreach ($root as $key_0 => $value_0) {
  foreach ($value_0 as $key_1 => $value_1) {
    if (isset($root[$key_0][$key_1]['settings'])) {
      if (isset($root[$key_0][$key_1]['settings']['property_separator'])) {
        $result['fields.' . $key_0 . '.'  . $key_1 . '.settings.property_separator'] = $root[$key_0][$key_1]['settings']['property_separator'];
      }
    }
  }
}

$replacement_separator = 'nl'; 
$config = \Drupal::configFactory()->getEditable('diff.plugins');
foreach ($result as $key => $value) {
  if (!is_string($value)) {
    $config->set($key, $replacement_separator);
  }
}
$config->save();

The first part should get you all configured property separators into $result. The second part sets non-string ones to $replacement_separator. This should fix the bug.

Sorry, I can't figure out what's wrong. Maybe someone else can help you.

I cannot reproduce the bug either. :(

Maybe it was just corrupted cache?

We cannot reproduce, can you check again please?

I was replicating this issue and found some more thumbnail related issues::

• There was mismatch in thumbnails count and placement of thumbnails in diff preview (For images more than three)
• Above mentioned notices were also coming

Attaching screenshots for the same and also the patch for the same issues.

Fixing above mentioned notices and there were some other errors like::

• Count of the thumbnails and the sequence is coming wrong (When there are more than three images uploaded)

Fixing these issues with the attached patch.

Count of the thumbnails and the sequence is coming wrong (When there are more than three images uploaded)

Is better to fix this kind of bugs/problems in a specific issue so we don't get out of scope.

Test failing.

Fixing above mentioned issue.

Thank you, we will need tests for this so we can know that the bug was fixed.
Don't forget to upload a test-only patch first. :)

Thanks for the patch @neelam.chaudhary !

I really works nicely and still applies to RC2.

+1 to patch #17 here. Working great on rc2

Hello
in 2021 with version 8.x-1.0 Stable release covered by the Drupal Security Team released 6 January 2020
I find the same error

Notice: Array to string conversion in Drupal\diff\Plugin\diff\Field\ImageFieldBuilder->build() (line 70 of modules/- dev/diff/src/Plugin/diff/Field/ImageFieldBuilder.php).
Drupal\diff\Plugin\diff\Field\ImageFieldBuilder->build(Object) (Line: 94)
Drupal\diff\DiffEntityParser->parseEntity(Object) (Line: 104)
Drupal\diff\DiffEntityComparison->compareRevisions(Object, Object) (Line: 115)
Drupal\diff\Plugin\diff\Layout\SplitFieldsDiffLayout->build(Object, Object, Object) (Line: 168)
Drupal\diff\Controller\PluginRevisionController->compareEntityRevisions(Object, Object, Object, 'split_fields') (Line: 49)
Drupal\diff\Controller\NodeRevisionController->compareNodeRevisions(Object, Object, Object, 'split_fields')
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 708)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
Notice: Array to string conversion in Drupal\diff\Plugin\diff\Field\ImageFieldBuilder->build() (line 70 of modules/- dev/diff/src/Plugin/diff/Field/ImageFieldBuilder.php).
Drupal\diff\Plugin\diff\Field\ImageFieldBuilder->build(Object) (Line: 94)
Drupal\diff\DiffEntityParser->parseEntity(Object) (Line: 105)
Drupal\diff\DiffEntityComparison->compareRevisions(Object, Object) (Line: 115)
Drupal\diff\Plugin\diff\Layout\SplitFieldsDiffLayout->build(Object, Object, Object) (Line: 168)
Drupal\diff\Controller\PluginRevisionController->compareEntityRevisions(Object, Object, Object, 'split_fields') (Line: 49)
Drupal\diff\Controller\NodeRevisionController->compareNodeRevisions(Object, Object, Object, 'split_fields')
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 708)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

The patch #17 or 8.x-1.x-dev not working
how to correct this problem?
thank you

+1 on patch fixing issue for me... thanks!

I am seeing this locally as well and the patch in #17 still applies to the latest code in 8.x-1.x branch and the PHP notices go away.

Please check the above MR.

Patch reroll

This is also needed for 2.x

Lots of people unable to reproduce this issue, I'll need steps to reproduce before reviewing code changes.

The problem is that $image_style is set implicitly and never unset after being used. That causes this issue, since that code runs in a loop. The issue only occurs when

• thumbnails are enabled in Diff
• the image is configured to be displayed in the form display with a preview image style
• there's more than 1 image in the field

It could be fixed by unsetting $image_style after using it, but I changed the code a bit to be more readable. I opened a new MR.

tests are now failing

In attempt to fix tests I've manually replicated test steps in a clean Drupal 10.3.6 installation with only Diff module installed - the output I saw on page was identical to that of the pipeline job, attaching as a screenshot below:

To me it appeared that the output produced by the module changed at some point, but the test wasn't updated to accommodate that change. However tests are passing on the latest 2.x...

I've reverted the change introduced here and saw expected output and no errors:

this is really weird as I saw all the errors reported in this issue myself on a project where we want to use this module...

Will spent some more time on this

The problem lies in the multi-valued field handling - image field in our project allows multiple image uploads.

As soon as I've changed field_image to be multivalued in the test instance and uploaded new image to a test article the same error appeared on the diff page.

Added multi-valued support and test. Everything is rudimentary as proper implementation should be done in #2840566: Make rich diff pluggable.

Tests and linting are failing

All green now.

Please review.

All green again and review comments addressed.

Please review.

Thanks for everyone's hard work getting this across the line, this will be included in the next beta

Why would you ignore other people's contributions and haven't given credit to them?

@makbay bit rude, but I credited everyone that provided valuable testing or contributions to this issue.

If I've missed someone then please let me know and I'll update it. You opened 2 MRs and immediately closed them.