As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.

Here is the summary of running ESLint on this module JS:
✖ 49 problems (49 errors, 0 warnings)

Attached is the full list of errors found by ESLint.

CommentFileSizeAuthor
#1 fix-eslint-errors-2490874.patch5.02 KBbès
diff-eslint-output.txt3.24 KBbès

Comments

bès’s picture

bès commented
Issue summary: View changes
StatusFileSize
new fix-eslint-errors-2490874.patch5.02 KB

Here is a patch that fix the small errors. Lots of them are about bad indentation be sure to configure your editor using the JavaScript coding standards.

bès’s picture

bès commented
Status: Active » Needs review

  • lhangea committed 4f62bd8 on 8.x-1.x authored by Bès 
    Issue #2490874 by Bès: Diff ESLint errors
lhangea’s picture

lhangea commented
Status: Needs review » Fixed

The test bot was stuck because of a fatal error with schema validation. About this one, I checked with eslint, the javascript is validated after applying the patch.

Thanks for your contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.