The Drupal Coding Standard Missing.
Please find the below link for more details.

https://pareview.sh/pareview/https-git.drupal.org-project-devel_queue.git

CommentFileSizeAuthor
#3 Screen Shot 2018-05-03 at 6.01.22 PM.png128.76 KBriddhi.addweb
#2 devel_queue-d7-2969212-#2.patch1.68 KBsureshcj

Comments

sureshcj created an issue. See original summary.

sureshcj’s picture

sureshcj commented
Status: Active » Needs review
StatusFileSize
new devel_queue-d7-2969212-#2.patch1.68 KB

Here I have fixed a few issues of coding standard.
Please review the patch.

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2018-05-03 at 6.01.22 PM.png128.76 KB

@sureshcj, Thanks for the patch, Your patch updates all the standard errors & now it is working fine. I review all over pareview.sh errors & attached the screenshots for the same.

  • amontero committed 774003b on 7.x-1.x 
    Issue #2969212 by sureshcj, riddhi.addweb: Fix coding standards.
amontero’s picture

amontero
Location Barcelona
commented
Status: Reviewed & tested by the community » Needs review

Thanks for the patch, @sureshcj.

However, some function comments are not correct because they don't implement any hooks and have 'Implements...' comments.
Also, some small functions are pretty obvious, so no docs are necessary, IMO.

That said, the other issues are legit and most of them addressed in #774003b. Leaving in CNR in case a new PAR run reveals more issues.