It is possible to generate an entity without selecting a Label Generation option. If using the default Entity Generator class, this will lead to entities with no label.

It could be said that this should be handled by custom entity generator classes, but if we make the form field required, we could use the default class that ships with the module.

Patch coming up.

CommentFileSizeAuthor
#2 devel_contrib_generate-require-label-option-2682517-1.patch571 byteswadmiraal

Comments

wadmiraal created an issue. See original summary.

wadmiraal’s picture

wadmiraal commented
Status: Active » Needs review
StatusFileSize
new devel_contrib_generate-require-label-option-2682517-1.patch571 bytes
joachim’s picture

joachim commented
Status: Needs review » Needs work

Thanks for the patch.

Though it doesn't apply -- the default value part got committed a while back:

commit 200a3a3befd49cbf590f96a8d79213ba18f1a087
Author: Joachim Noreiko <joachim@107701.no-reply.drupal.org>
Date:   Wed Jan 6 11:59:01 2016 +0000

    Fixed missing default value in generate form.

You should always do a git pull before working on a patch! :)

wadmiraal’s picture

wadmiraal commented
Status: Needs work » Closed (duplicate)

Ha! n00b mistake :-D. Closing, thx.