Problem/Motivation

Code sniffer for PHP 7.4 reports one warning:

-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------
 167 | WARNING | Passing the $glue and $pieces parameters in reverse order to implode has been
     |         | deprecated since PHP 7.4; $glue should be the first parameter and $pieces the
     |         | second
-------------------------------------------------------------------------------------------------

Steps to reproduce

Run phpcs with the PHP compatibility set to version 7.4

Proposed resolution

Switch the order of the arguments to implode()

Remaining tasks

Code review

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 defaultcontent-php74-implode-3172478-2.patch580 bytescboyden

Comments

cboyden created an issue. See original summary.

cboyden’s picture

cboyden commented
Assigned: cboyden » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new defaultcontent-php74-implode-3172478-2.patch580 bytes

Patch is attached.

mohangathala’s picture

mohangathala commented
Status: Needs review » Reviewed & tested by the community

Patch #2 works for me.

rajatc’s picture

rajatc commented

Patch #2 works to me for PHP 7.4 warning.