In Exporter::getEntityIdsForExport(), the bundle key is set to "type", with or "vid" for terms & "menu_name" for menu items. Rather than explicit these, we should use the entity type definition to get the bundle key. (Or, for example, exports of core Media with bundle option won't work).

Patch attached should fix this.

CommentFileSizeAuthor
#2 3015174-default_content-use_bundle_key.patch857 bytesbgilhome

Comments

bgilhome created an issue. See original summary.

bgilhome’s picture

bgilhome commented
StatusFileSize
new 3015174-default_content-use_bundle_key.patch857 bytes
martin_klima’s picture

martin_klima
he/his
Primary language Czech
commented

Yes, it is a good point. You fix very old part of code, where we did not know much about D8 :)
Thank you!

I will commit soon.

  • martin_klima committed a4fc94e on 8.x-1.x authored by bgilhome 
    Issue #3015174 by bgilhome: Use entity type definition to get bundle key
martin_klima’s picture

martin_klima
he/his
Primary language Czech
commented
Status: Needs review » Fixed
martin_klima’s picture

martin_klima
he/his
Primary language Czech
commented
Status: Fixed » Needs work

We expect $bundleType == 'menu_name' for entity type "menu_link_content", but we get $bundleType == 'bundle'.
It corrupts exporting of menu links from given menu name.

  • martin_klima committed f67877d on 8.x-1.x 
    Issue #3015174 by bgilhome, martin_klima: Fix bundle key for...
martin_klima’s picture

martin_klima
he/his
Primary language Czech
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.