Hey Guys,

I noticed that the JS for this module was being appended to the page over several lines so i modified the code slightly to do it over one line using a single call to "druapl add js inline" via a variable.

I thought it might also be nice if the settings could be set in an attached js file to allow drupal to aggregate it.

anyway I have created a patch to do the above let me know what you think.

Regards

CommentFileSizeAuthor
jscleanup.patch4.16 KBsduff_07

Comments

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Active » Fixed

Hi sduff_07,

Thanks for the patch, I opted for an alternative approach however as it's important that the configuration be configurable, and you're code would means that it's either cacheable or configurable but not both. Instead, I've opted to have the configuration written to code (public://deepzoom/deepzoom_config.js), which makes it both configurable and cacheable.

Committed - http://drupalcode.org/project/deepzoom.git/commitdiff/2f731a362e5acc9c77...

Cheers,
Deciphered.

richardhayward’s picture

richardhayward commented

Thanks Deciphered!

sduff_07’s picture

sduff_07 commented

ahh this missing link, just what i was after.

thanks

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.