date_popup_css_default() does not conform to what date_popup_css_options() returns as default. It always returns datepicker.css (jquery 1.6), even if 1.7 is being used.

CommentFileSizeAuthor
#7 jquery-date-popup.png22.11 KBgeerlingguy
date_popup_default.patch673 bytesslip

Comments

slip’s picture

note: accidentally made the patch in date_popup/

ericduran’s picture

Status: Active » Reviewed & tested by the community

I tested this and it fixed my issues with the wrong css.

slip’s picture

Title: datepicker.1.7.css not loaded as default if jQuery 1.7 in use » datepicker.1.7.css not loaded as default if jQuery UI 1.7 in use

jquery ui, not jquery.

slip’s picture

We might consider adding module_exists('jquery_ui') in this patch because right now date_popup_init will attempt to load the default css file even if jquery_ui is disabled and that causes an error when jquery_ui_get_version() is called.

karens’s picture

Status: Reviewed & tested by the community » Fixed

Committed, thanks! I added a test for jquery_ui also.

geerlingguy’s picture

I just downloaded the latest -dev release of date.module, and I'm still seeing unstyled popups - they work better, but no styling is applied. I'm using jQuery UI 1.7.x...

geerlingguy’s picture

Status: Fixed » Active
StatusFileSize
new22.11 KB

Setting back to active to ask: is the attached how the datepicker is supposed to look? I just installed the latest -dev release of date.module (Dec. 13), and the date popup doesn't look anything like it used to before I installed jQuery UI 1.7.x (with jQuery Update 1.4.x).

apmsooner’s picture

Thats not how its supposed to look and I have the same problem. I'm hoping this gets fixed in a dev release soon.

marcoka’s picture

same here:
It always returns datepicker.css (jquery 1.6), even if 1.7 is being used.
i changed the:

drupal_add_css(variable_get('date_popup_css_file', date_popup_css_default()));

with the variable editor to the right css, now it looks like in the screenshot postet above

xjm’s picture

Status: Active » Closed (duplicate)