The description of date_popup_input_value lists this parameter:
@param autocomplete -- Should we add a time value to complete the date if there is no time?
That parameter is defined with a default value of FALSE, but the parameter is never used anywhere in the function. As a result, the always time is filled into the date.
There is a trivial fix for this -- the last "if" clause of the function is what accomplishes the auto completion, and hence it could be skipped if auto_complete == FALSE. However, since that is the default value, many things may break because they depend on the buggy behavior.
I suppose that a third parameter could be introduced to the function, and the second parameter renamed to unused or something. Is there a better way to fix that?
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | date-date_popup_input_value.patch | 1.94 KB | klflote |
Comments
Comment #1
klflote commentedHere is a patch that fixes this problem; for backward-compatibility, the second parameters is ignored, and the default value for autocomplete is TRUE.
Comment #2
damienmckennaUnfortunately the Drupal 6 version of the Date module is no longer supported. That said, we appreciate that you took time to work on this issue. Should this request still be relevant for Drupal 7 please feel free to reopen it. Thank you.