Patch for fixing following errors generated by phpcs while checking for PHP 8 compatibility issues.

FILE: /var/www/docroot/sites/all/modules/contrib/date/date_popup/date_popup.module
---------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
270 | WARNING | Declaring a required parameter after an optional one is deprecated since PHP 8.0.
| | Parameter $input is optional, while parameter $form_state is required.
---------------------------------------------------------------------------------------------------

FILE: /var/www/docroot/sites/all/modules/contrib/date/date_repeat_field/date_repeat_field.module
---------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
442 | WARNING | Declaring a required parameter after an optional one is deprecated since PHP 8.0.
| | Parameter $rrule is optional, while parameter $field is required.
442 | WARNING | Declaring a required parameter after an optional one is deprecated since PHP 8.0.
| | Parameter $rrule is optional, while parameter $item is required.
---------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#2 php8-compatibility-3271049.patch1.31 KBsudheeshps

Comments

sudheeshps created an issue. See original summary.

sudheeshps’s picture

sudheeshps commented
Status: Active » Needs review
StatusFileSize
new php8-compatibility-3271049.patch1.31 KB

Updated patch

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Related issues: +#3272127: Plan for date 7.x-3.0-alpha2
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: sudheeshps » Unassigned
Parent issue: » #3241397: Plan for Date 7.x-2.13

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: PHP 8 compatibility issues » PHP 8 compatibility - required function arguments after optional ones
Status: Needs review » Fixed

Committed. Thank you.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Fixed » Reviewed & tested by the community

Needs to be committed to the 7.x-3.x branch too.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

w00t!

Thanks so much @DamienMcKenna

so many great contributors on Drupal.org just want to say thanks. Jacob Rockowitz has done a lot of great work as well but I think you're maybe one of the best of all time!

really nice to get these PHP 8.0 and PHP 8.1 fixes in while we still can.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.