Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Provide a rewritten date_all_day_update_7200() that updates all appropriate data to use the is_all_day element of date fields added in #3202962: Expand field specification with new element for "all day".
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | date-n3201878-10.patch | 9.15 KB | damienmckenna |
| #6 | date-n3201878-6.patch | 1.66 KB | damienmckenna |
Comments
Comment #2
damienmckennaComment #3
liam morlandMade link in summary work.
Comment #4
solideogloria commentedJust a note that the first line of the function has
// Get all fields provided by the Data module., and it should beDate module. Might as well fix that here, too.Comment #5
damienmckennaI think the db_update() query could also be modified to update all records with the same value instead of doing it one record at a time, and then just flush all entity caches when it's finished.
Comment #6
damienmckennaThis is what I'm thinking of.
Comment #7
damienmckennaStill needs sandbox processing to be added, and test coverage to be expanded.
Comment #8
damienmckennaFYI there's a separate issue at #3201981: Update to 7.x-2.11 "broke" repeating all-day dates for fixing the logic itself, for this update script I'd like to focus on the sandbox & performance logic.
Comment #9
damienmckennaComment #10
damienmckennaRerolled after #3206100.
Comment #11
damienmckennaThis will also need to be rewritten to leverage #3202962: Expand field specification with new element for "all day".
Comment #12
damienmckennaRewriting the purpose of this issue.
Comment #13
jrochate commentedI don't if it's related, but my previous date field all-day with start and end, could no longer be used as a filter on views using the end_date.
The trick was to resave the node, and now the view works again.
Comment #14
damienmckennaA lot of work has gone into #3202962 focused on making the functionality work correctly, so this one will be focused on on updating existing data.
Comment #15
damienmckennaComment #16
damienmckennaComment #17
damienmckennaComment #18
joseph.olstadComment #19
joseph.olstadComment #20
kevin morse commentedWhat is still remaining for this issue?
It seems this is the only issue blocking https://www.drupal.org/project/date/issues/3308472
Comment #21
joseph.olstad@Kevin Morse,
The remaining work is to adapt patch 10 to use the approach mentioned/linked in comment #11