Hello,

We are using the Swedish language where every heading in the datepicker use 3 letters. What would be the best solution for this?

Maybe this should be slightly more dynamic (taken from Chrome's inspector, might be wrong):

.ui-datepicker {
width: 17em;
padding: .2em .2em 0;
}

Best Eric

CommentFileSizeAuthor
#7 date-n2291271-after.png28.42 KBdamienmckenna
#4 date_before.png12.73 KBLoonyLuna
#4 date_after.png12.75 KBLoonyLuna
#2 date_sv_version.png34.16 KBLoonyLuna
#2 date_en_version.png31.32 KBLoonyLuna
#1 date-datepicker_dynamic_width-2291271-1.patch710 bytesemek
Datepicker bug.png42.05 KBperiksson

Comments

emek’s picture

emek commented
Version: 7.x-2.6 » 7.x-2.x-dev
Component: Code » Date Popup
Status: Active » Needs review
StatusFileSize
new date-datepicker_dynamic_width-2291271-1.patch710 bytes

I noticed the same problem (also using swedish) and I fixed it by changing the width to auto, now it works for both english and swedish.

LoonyLuna’s picture

LoonyLuna commented
StatusFileSize
new date_en_version.png31.32 KB
new date_sv_version.png34.16 KB

Hi,
I would like to review this for you, but I can't really reproduce the problem.
What did I do:
- Set up simplytestme site
- added swedish as language and imported the translations
- added a new popup date field to default content type article
- tried to create a new article and find the problem

Can you describe in what place you found this bug?

emek’s picture

emek commented

I am able to reproduce it with your steps. I see the error when using firefox dev edition, chrome and safari on mac.

LoonyLuna’s picture

LoonyLuna commented
StatusFileSize
new date_after.png12.75 KB
new date_before.png12.73 KB

Okay thank you! I tested it in chrome and chromium, but the bug doesn't appeared. But I tested it in Firefox and I could see the problem.

The patch works! (See screenshots)

It's my first review, so I guess someone else has to review it too, before it changes to "Reviewed and tested by community"?

LoonyLuna’s picture

LoonyLuna commented
Status: Needs review » Reviewed & tested by the community

Okay I set it to "Reviewed & tested by the community", because I think the changes are working with no side-effects.

  • DamienMcKenna committed d113587 on 7.x-2.x authored by emek 
    Issue #2291271 by emek, LoonyLuna, periksson: Datepicker needs dynamic...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed
Parent issue: » #2867810: Plan for Date 7.x-2.11 release
StatusFileSize
new date-n2291271-after.png28.42 KB

This seems to work nicely, e.g.:
Dynamic width

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.