Closed (fixed)
Project:
Date
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
25 Aug 2007 at 02:49 UTC
Updated:
14 Feb 2008 at 00:16 UTC
Jump to comment: Most recent file
Comments
Comment #1
thepanz commentedMaybe you can display the first date complete, then only the HH:MM of the second in your theming functions..
Comment #2
aren cambre commentedI hear you, but the point of creating standardized modules with useful features is to allow users to avoid custom coding.
Comment #3
thepanz commentedHi created that patch, it display only "hh:mm" of the date-to if the two dates are in the same day: if date_from->timestamp - date_to->timestamp is less than one day in seconds..
Let me know
patch is against DRUPAL-5 branch..
Comment #4
thepanz commentedI checked the HEAD version of Date module, this fix is already in!
Comment #5
karens commentedHmm, no I didn't commit this change. It won't work quite right because you're using 24 hour time which may or may not be right, plus you haven't taken into account situations where the time wasn't supposed to show at all, you're code would display time no matter what. So this is not the right way to fix this.
This is actually harder than it sounds to do, which is why it isn't done.
Comment #6
thepanz commentedHi KarenS, my patch was olny a really dirty edit of your module, I didn't except (neither want) that my patch could be committed in (I set Patch-need-work for that reason)!
oh, in HEAD version this feature isn't implemented yet, what I said in #4 isn't right!
Comment #7
karens commentedThis should be fixed in the 5.2 version, which is not quite ready for an official release. You can see that release if you look for 'other releases' on the project page. Try it in a test environment, or be prepared to update it as bugs are found and fixed.
Comment #8
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.